Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): Soft deleted Bucket Restore #28138
base: main
Are you sure you want to change the base?
feat(storage): Soft deleted Bucket Restore #28138
Changes from all commits
0f5b378
c13c271
703a74f
113e074
d8389ee
4805dcf
4628b57
331713a
7bb513c
fd595ed
5876b21
8bb3590
0c7316a
dc22c71
45c0bc7
2e96036
3728dcf
4265f54
3c89fef
d3e3db6
36fbf02
69a242b
46b987e
0d902d5
b187c21
b608825
cc5dd1e
6700876
9538c91
ae9e2af
dbdbe58
d67ebf4
f30c889
8040fab
88438a3
70236f7
b2f67ad
6108636
04a56f1
dcb47e7
360f07a
f42e11d
49834d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error occurs at this line. This could be because the bucket_name is modified in the previous line and the new bucket doesn't exist.
Like Jesse said, try removing the above line. We shouldn't be modifying the bucket_name passed.