Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for array and float32 SQL query params #1075

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jackdingilian
Copy link
Contributor

@jackdingilian jackdingilian commented Jan 17, 2025

One note: we currently support inferring the type of simple query params. Here I opt not to attempt this for lists. We could infer the type from the first element of the list (and error if it is None, or infer from the first non-null element). For now I think this approach is less error prone, and we can ease this restriction in the future

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jackdingilian jackdingilian requested review from a team as code owners January 17, 2025 15:14
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 17, 2025
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jan 17, 2025
@jackdingilian jackdingilian force-pushed the array-param-support branch 2 times, most recently from 2dee92c to ddaa591 Compare January 17, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants