Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: drop support for Ruby 2.6 #268

Merged
merged 2 commits into from
Nov 3, 2023
Merged

deps: drop support for Ruby 2.6 #268

merged 2 commits into from
Nov 3, 2023

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Nov 2, 2023

The Google Cloud libraries have already dropped suppport for Ruby 2.6, and now the build is failing because the latest version of the google-protobuf libraries require 2.7 or higher.

See also https://github.com/googleapis/ruby-spanner-activerecord/actions/runs/6728914269/job/18288964465 and https://cloud.google.com/ruby/getting-started/supported-ruby-versions

The Google Cloud libraries have already dropped suppport for Ruby 2.6, and
now the build is failing because the latest version of the google-protobuf
libraries require 2.7 or higher.

See also https://github.com/googleapis/ruby-spanner-activerecord/actions/runs/6728914269/job/18288964465

* docs: update README to reference PGAdapter for PG

* chore: use a branch-independent link
@olavloite olavloite requested a review from a team as a code owner November 2, 2023 16:15
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. label Nov 2, 2023
@olavloite olavloite requested a review from hengfengli November 2, 2023 16:22
@olavloite olavloite changed the title docs: update README to reference PGAdapter for PG (#263) deps: drop support for Ruby 2.6 Nov 2, 2023
Copy link
Collaborator

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@olavloite olavloite merged commit af940ac into main Nov 3, 2023
27 checks passed
@olavloite olavloite deleted the drop-ruby-2.6-support branch November 3, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/ruby-spanner-activerecord API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants