Fix reading pre-game lobby chat in HD Edition. Fixes #29

goto-bus-stop · Dec 8, 2016 · 2621ef9 · 2621ef9
1 parent 5035738
commit 2621ef9
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Analyzers/HeaderAnalyzer.php b/src/Analyzers/HeaderAnalyzer.php
@@ -112,6 +112,10 @@ protected function run()
             $this->position += 1;
         }
 
+        if ($version->isHDEdition) {
+            $this->position += 4;
+        }
+
         $pregameChat = [];
         if ($version->isMgx) {
             $pregameChat = $this->readChat($playersByIndex);

diff --git a/test/HeaderAnalyzerTest.php b/test/HeaderAnalyzerTest.php
@@ -103,6 +103,16 @@ public function testAoe2RecordVictorySettings()
         $this->assertAttributeEquals(9000, 'timeLimit', $analysis->victory);
     }
 
+    /**
+     * @dataProvider chatCountsProvider
+     */
+    public function testChat($file, $expectedCount)
+    {
+        $rec = $this->load($file);
+        $analysis = $rec->runAnalyzer(new HeaderAnalyzer);
+        $this->assertCount($expectedCount, $analysis->pregameChat);
+    }
+
     public function playersProvider()
     {
         return [
@@ -160,4 +170,12 @@ public function playersProvider()
             ], 2],
         ];
     }
+
+    public function chatCountsProvider()
+    {
+        return [
+            ['recs/versions/HD Tourney r1 robo_boro vs Dutch Class g1.aoe2record', 13],
+            ['recs/versions/HD_test.mgx', 50],
+        ];
+    }
 }