-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: accessibility changes #134
Conversation
(I haven't tried these changes locally but...) It looks like a good start, thanks! |
…se it was aria-hidden anyways(?)
… become law page has div issue
…e without styles enabled
Hey, is this ready to merge? |
I can get it in shape soon (today/tomorrow). There are a few changes
needed like restyling headers after I reordered some H2s and 3's
…On Mon, Jul 31, 2017 at 6:29 AM, Joshua Tauberer ***@***.***> wrote:
Hey, is this ready to merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#134 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHnREg6-BZiyhDlxGeu_BJ-UrloM2swks5sTci7gaJpZM4N2ddv>
.
|
Would it be a problem for me to merge in master to this for testing all the new changes? (This forked from cloud-deployment which doesn't appear to be merged into master yet...) |
I pushed some rudimentary changes to headings. Some headings needed to be changed from h2 <--> h3 and also I added headings to tab body's when the content of the tab was important. For the tabs... repeating the tab title in the tab pane does seem pretty duplicative but without a real header the document structure does seem pretty lacking. Some examples below... feedback encouraged. |
I added some commits to support text alternatives for screen readers. I tried to add a description to the sponsorship analysis and added the screen reader plugin for highcharts. I also added pending to the bill history table. I suppose technically it wasn't necessary since a user that is unable to see colors would be able to infer from the lack of a date that an event hasn't happened yet... |
Merged, thanks! I merged master into the branch, as well as some other major changes like upgrading Django from 1.7 to 1.11. I'm taking this opportunity to get as many ducks in a row as possible. |
Starting to work on the accessibility issues described in #129. Some of these are likely to require discussion.