Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: accessibility changes #134

Merged
merged 23 commits into from
Aug 2, 2017

Conversation

joelcollinsdc
Copy link
Contributor

Starting to work on the accessibility issues described in #129. Some of these are likely to require discussion.

@JoshData
Copy link
Member

(I haven't tried these changes locally but...) It looks like a good start, thanks!

@joelcollinsdc
Copy link
Contributor Author

Pushed a commit (-f, hope that was OK) that tries to make the tabbed navigating look similar to mouse navigation. Tested in safari and chrome, firefox keyboard navigating confuses me.

image

@JoshData
Copy link
Member

Hey, is this ready to merge?

@joelcollinsdc
Copy link
Contributor Author

joelcollinsdc commented Jul 31, 2017 via email

@joelcollinsdc
Copy link
Contributor Author

joelcollinsdc commented Aug 2, 2017

Would it be a problem for me to merge in master to this for testing all the new changes? (This forked from cloud-deployment which doesn't appear to be merged into master yet...)
(there are actually a lot of conflicts, i'm hoping at least some/most are from the cloud_deployment stuff, maybe I should wait? The home page has changed considerably though, so I feel like catching up is necessary...)

@joelcollinsdc
Copy link
Contributor Author

I pushed some rudimentary changes to headings. Some headings needed to be changed from h2 <--> h3 and also I added headings to tab body's when the content of the tab was important. For the tabs... repeating the tab title in the tab pane does seem pretty duplicative but without a real header the document structure does seem pretty lacking. Some examples below... feedback encouraged.

screen shot 2017-08-02 at 12 29 21 am

screen shot 2017-08-02 at 12 27 27 am

@joelcollinsdc
Copy link
Contributor Author

I added some commits to support text alternatives for screen readers. I tried to add a description to the sponsorship analysis and added the screen reader plugin for highcharts.

screen shot 2017-08-02 at 1 35 16 am

I also added pending to the bill history table. I suppose technically it wasn't necessary since a user that is unable to see colors would be able to infer from the lack of a date that an event hasn't happened yet...

image

@JoshData JoshData merged commit 05ae00d into govtrack:cloud_deployment Aug 2, 2017
@JoshData
Copy link
Member

JoshData commented Aug 2, 2017

Merged, thanks! I merged master into the branch, as well as some other major changes like upgrading Django from 1.7 to 1.11. I'm taking this opportunity to get as many ducks in a row as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants