Skip to content

Separate AXE specs - #3102

Merged
chao-xian merged 2 commits into
mainfrom
speed-up-specs
Sep 18, 2026
Merged

chao-xian merged 2 commits into
mainfrom
speed-up-specs

Conversation

@chao-xian

@chao-xian chao-xian commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Specs are like 7-11 minutes to run on local machines (even on snappy new MBPs it's ~5mins at best)

Taken the strategy of cutting out from running on local dev the AXE specs as we don't really touch these much.

This saves us between 20 to 60 seconds (whereas other strategies I tried would save about 10 seconds)

Trello card: https://trello.com/c/kg2N9Zpu/3217-timebox-1-day-speed-up-forms-admin-tests

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@chao-xian chao-xian changed the title Speed up specs Separate AXE specs Sep 15, 2026
These are among our slowest tests, and barely change. Switching this to run by default on our infrastructure and not as part of local development where the tests are slowest to run.
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3102.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@chao-xian
chao-xian added this pull request to the merge queue Sep 18, 2026
Merged via the queue into main with commit 9e5022d Sep 18, 2026
4 checks passed
@chao-xian
chao-xian deleted the speed-up-specs branch September 18, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants