Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and tests for CPE matches #60

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Jan 8, 2025

What

  • Added tests for the CPE match CLI classes
  • ScapProcessor now uses the correct default queue size
  • request_filter_opts are not updated if since is None
  • CPE match caching no longer erroneously removes keys where snake_case and camelCase are the same

Why

References

GEA-790

Checklist

  • Tests

The request_filter_opts are not updated in that case.
The add_args_to_parser function was erroneously using
 the chunk size default for the --queue-size default.
Copy link

github-actions bot commented Jan 8, 2025

Conventional Commits Report

Type Number
Bug Fixes 3
Added 1

🚀 Conventional commits found.

Dict keys were erroneously deleted if they were the same in snake_case and camelCase.
The filename now uses underscores, so the tests are updated accordingly.
@timopollmeier timopollmeier marked this pull request as ready for review January 9, 2025 09:03
@timopollmeier timopollmeier requested review from a team as code owners January 9, 2025 09:03
@bjoernricks bjoernricks merged commit e2833c5 into main Jan 9, 2025
11 checks passed
@bjoernricks bjoernricks deleted the cpe-match-fixes-and-tests-2 branch January 9, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants