Change: Encode CPE match strings directly to file #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
The JSON downloader for CPE match strings now writes the encoded chunks of the JSON dict directly to the output file and only buffer it in memory if validation is requested. This reduces the amount of memory used for creating the output file after the data has been downloaded from the API.
timopollmeier
force-pushed
the
encode-matches-to-file
branch
from
1df2a47 to
17b28d0
Compare
y0urself
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The JSON downloader for CPE match strings now writes the encoded chunks of the JSON dict directly to the output file and only buffer it in memory if validation is requested.
Why
This reduces the amount of memory used for creating the output file after the data has been downloaded from the API.
References
GEA-820
Checklist