Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AT-1250 quality gates #145

Merged
merged 3 commits into from
Feb 14, 2024
Merged

AT-1250 quality gates #145

merged 3 commits into from
Feb 14, 2024

Conversation

larox11
Copy link
Contributor

@larox11 larox11 commented Feb 7, 2024 •
edited
Loading

What

  • Change README title to "OpenSight Keycloak Client"

Why

pass quality gates

References

AT-1250

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@larox11 larox11 marked this pull request as ready for review February 14, 2024 11:20
@larox11 larox11 requested a review from a team as a code owner February 14, 2024 11:20
y0urself
y0urself reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@y0urself y0urself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I also rename the repository?
This is a thorn in my eye since it has been renamed ...

@y0urself y0urself enabled auto-merge February 14, 2024 11:26
@y0urself y0urself merged commit 96d93a8 into main Feb 14, 2024
7 checks passed
@y0urself y0urself deleted the AT-1250-quality-gate branch February 14, 2024 11:26
@larox11
Copy link
Contributor Author

larox11 commented Feb 14, 2024

Can I also rename the repository? This is a thorn in my eye since it has been renamed ...

The asset team decided on this name. What is the issue with it in your eyes?

@y0urself
Copy link
Member

Can I also rename the repository? This is a thorn in my eye since it has been renamed ...

The asset team decided on this name. What is the issue with it in your eyes?

I don't think it is necessary to mention the programming language, It would be much better aligned with opensight-keycloak-client

@larox11
Copy link
Contributor Author

larox11 commented Feb 14, 2024

Can I also rename the repository? This is a thorn in my eye since it has been renamed ...

The asset team decided on this name. What is the issue with it in your eyes?

I don't think it is necessary to mention the programming language, It would be much better aligned with opensight-keycloak-client

The idea behind this was that the name makes it clear that this is a golang library and only useful for go applications. Who do you think should decide on the name? Shall I take it to the asset team since this is an asset-specific repo?

@y0urself
Copy link
Member

y0urself commented Feb 14, 2024 •
edited
Loading

Can I also rename the repository? This is a thorn in my eye since it has been renamed ...

The asset team decided on this name. What is the issue with it in your eyes?

I don't think it is necessary to mention the programming language, It would be much better aligned with opensight-keycloak-client

The idea behind this was that the name makes it clear that this is a golang library and only useful for go applications. Who do you think should decide on the name? Shall I take it to the asset team since this is an asset-specific repo?

In the end it's up to you(r) team.

IMHO there are enough indicators for it's being "golang", e.g.:

Bildschirmfoto 2024-02-14 um 12 39 42
Bildschirmfoto 2024-02-14 um 12 39 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0urself y0urself y0urself approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larox11 @y0urself