Add: client authorization on endpoints #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
force-pushed
the
rs-mtls-authenticator
branch
2 times, most recently
from
6f9f409 to
7c85b84
Compare
nichtsfrei
changed the title
nichtsfrei
force-pushed
the
rs-mtls-authenticator
branch
4 times, most recently
from
23121ff to
bccfe22
Compare
nichtsfrei
force-pushed
the
rs-mtls-authenticator
branch
3 times, most recently
from
6c1828c to
7f82b92
Compare
To prevent that a registered client can see results or scan of another client a differentiation factor is introduces. The scans and results will now be stored as an u64->information and the key is either calculated by the used client certificate or, when openvasd is started without client certifactes, by the used API key. When client certificates and the API key is configured than the client certificates are getting used. When neither is configured the scans endpoints are unreachable.
nichtsfrei
force-pushed
the
rs-mtls-authenticator
branch
from
7f82b92 to
b606c95
Compare
When client certificates are enabled than it must no be possible to test a network by using the API-Key. To disable that the API-Key is disabled when client certificates are enabled and a warning is printed.
jjnicola
approved these changes
Nov 6, 2023
Kraemii
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent that a registered client can see results
or scan of another client a differentiation factor
is introduces.
The scans and results will now be stored as an u64->information and the
key is either calculated by the used client certificate or, when openvasd
is started without client certifactes, by the used API key.
When client certificates and the API key is configured than the client
certificates are getting used.
When neither is configured the scans endpoints are unreachable.
SC-949 SC-950