Introduce a base enum class #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will simplify all our enums and reduce duplicate code.
Some enums like ScannerType and AliveTest are special and don't need to be derived from our base enum class. Using our base enum class for all other enums allows to remove all from_string methods and therefore avoids code duplication.
Conventional Commits Report
🚀 Conventional commits found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implement a base enum class for our type classes in python-gvm
Why
The current implementation before this PR contains from_string methods for every type. Introducing a base enum class avoids code duplication by using a generalized from_string method.
Checklist