Skip to content

enable composite assembling for modification references - #4198

Draft
Mathieu-Deharbe wants to merge 2 commits into
mainfrom
fix-reference-updates
Draft

Mathieu-Deharbe wants to merge 2 commits into
mainfrom
fix-reference-updates

Conversation

@Mathieu-Deharbe

Copy link
Copy Markdown
Contributor

was disabled because the references modification were not handled in the back but now they are : gridsuite/study-server#1096

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
Mathieu-Deharbe marked this pull request as draft September 14, 2026 14:15
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 34541350-cd24-4898-8280-5452331f62d5

📥 Commits

Reviewing files that changed from the base of the PR and between 7e8b834 and 43d2bf3.

📒 Files selected for processing (1)
  • src/components/graph/menus/network-modifications/network-modification-node-editor.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The composite creation action no longer becomes disabled when the current selection contains a shared modification.

Changes

Composite creation

Layer / File(s) Summary
Update composite creation rule
src/components/graph/menus/network-modifications/network-modification-node-editor.tsx
The disabled-state memo no longer uses selectionContainsShared. Shared modifications no longer block the “Assemble Into Composite” action.

Suggested reviewers: souissimai

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 43d2b

Composite creation with shared modifications follows the supported backend path, and no concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: enabling composite assembling for modification references.
Description check ✅ Passed The description explains why the feature was previously disabled and states that backend support is now available.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@Mathieu-Deharbe Mathieu-Deharbe self-assigned this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant