Changes in knative definition

grycap · Nov 24, 2023 · f6839a9 · f6839a9
1 parent 4054087
commit f6839a9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/pkg/backends/knative.go b/pkg/backends/knative.go
@@ -102,14 +102,6 @@ func (kn *KnativeBackend) CreateService(service types.Service) error {
 		return err
 	}
 
-	if service.VO != "" {
-		for _, vo := range kn.config.OIDCGroups {
-			if vo == service.VO {
-				service.Labels["vo"] = service.VO
-			}
-		}
-	}
-
 	// Create the Knative service definition
 	knSvc, err := kn.createKNServiceDefinition(&service)
 	if err != nil {
@@ -286,6 +278,14 @@ func (kn *KnativeBackend) createKNServiceDefinition(service *types.Service) (*kn
 	// https://knative.dev/docs/serving/services/private-services/
 	service.Labels[types.KnativeVisibilityLabel] = types.KnativeClusterLocalValue
 
+	if service.VO != "" {
+		for _, vo := range kn.config.OIDCGroups {
+			if vo == service.VO {
+				service.Labels["vo"] = service.VO
+			}
+		}
+	}
+
 	podSpec, err := service.ToPodSpec(kn.config)
 	if err != nil {
 		return nil, err

diff --git a/pkg/types/service_test.go b/pkg/types/service_test.go
@@ -216,7 +216,6 @@ total_memory: ""
 total_cpu: ""
 enable_gpu: false
 enable_sgx: false
-vo: ""
 image_prefetch: false
 synchronous:
   min_scale: 0
@@ -252,6 +251,7 @@ environment:
     TEST_VAR: testvalue
 annotations:
   testannotation: testannotationvalue
+vo: ""
 labels:
   testlabel: testlabelvalue
 storage_providers: