-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Feature/1570-layercomparerselection #1573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunix71
requested review from
jacobwod and
Hallbergs
and removed request for
Hallbergs
December 23, 2024 02:06
jacobwod
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, I like the selector in Admin too!
Thank you so much for your feedback! It makes me happy :-) @jacobwod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to dynamically select layers for comparison in the LayerComparer component. Key features include:
Layer Selection: Users can now choose specific layers to compare directly in the admin interface.
Dynamic Updates: The component stays in sync with changes to the layerMenuConfig configuration, ensuring the list of layers reflects the current state.
Improved Usability: Added safeguards to handle inactive or missing layers gracefully, reducing potential errors and confusion.
Please review and test the changes to ensure seamless integration with the existing functionality.