Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Feature/1570-layercomparerselection #1573

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

Sunix71
Copy link
Contributor

@Sunix71 Sunix71 commented Dec 19, 2024

This pull request introduces the ability to dynamically select layers for comparison in the LayerComparer component. Key features include:

Layer Selection: Users can now choose specific layers to compare directly in the admin interface.
Dynamic Updates: The component stays in sync with changes to the layerMenuConfig configuration, ensuring the list of layers reflects the current state.
Improved Usability: Added safeguards to handle inactive or missing layers gracefully, reducing potential errors and confusion.

Please review and test the changes to ensure seamless integration with the existing functionality.

@Sunix71 Sunix71 linked an issue Dec 20, 2024 that may be closed by this pull request
@Sunix71 Sunix71 requested review from jacobwod and Hallbergs and removed request for Hallbergs December 23, 2024 02:06
Copy link
Member

@jacobwod jacobwod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I like the selector in Admin too!

@jacobwod jacobwod merged commit fccf4b7 into develop Jan 7, 2025
@jacobwod jacobwod deleted the feature/1570-layercomparerselection branch January 7, 2025 12:27
@Sunix71
Copy link
Contributor Author

Sunix71 commented Jan 7, 2025

Thank you so much for your feedback! It makes me happy :-) @jacobwod
I appreciate you taking the time to review my pull request and I’m glad you liked the selector in Admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LayerComparer: Add Layer Selection for Comparisons
2 participants