Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all deprecated dependencies #519

Merged
merged 18 commits into from
Nov 4, 2023

Conversation

jlengrand
Copy link
Contributor

@jlengrand jlengrand commented Oct 8, 2020

  • Upgrades chalk to 4.1.0
  • Upgrades cosmiconfig to 7.0.0
  • Upgrades uglifyjs-webpack-plugin to 2.2.0
  • Upgrades copy-webpack-plugin to 6.2.0
  • Upgrades sockjs-client to 1.5.0
  • Upgrades optimize-css-assets-webpack-plugin to 5.0.4
  • Upgrades assets-webpack-plugin to 5.1.2
  • Upgrades workbox-webpack-plugin to 5.1.4
  • Upgrades react-error-overlay to 6.0.7
  • Upgrades http-proxy-middleware to 1.0.5
  • Upgrades fs-extra to 9.0.1
  • Upgrades react-dev-utils to 10.2.1

closes #322 #510 #454 #460 #507 #506 #473 #457 #444 #429 #421 #404

@jlengrand
Copy link
Contributor Author

Can you add the hacktoberfest-accepted tag to that PR by any chance @halfzebra ?

@jlengrand jlengrand changed the title WIP: Update deprecated dependencies Upgrade all deprecated dependencies Oct 8, 2020
@Slumber86
Copy link
Contributor

Slumber86 commented Oct 21, 2020

I'm commenting just to point out that react-dev-utils is breaking the build, we are tryng to update it for months but is full of breaking changes. @jlengrand please consider to remove the update

@jlengrand
Copy link
Contributor Author

Interesting, thanks for the info! In what way does it break the build? Both CIs pass and I have been running the thing locally without issues?

Can you give some more context so I can look into it please?

@Slumber86
Copy link
Contributor

It shows a white page with this errror:

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined at validateString (internal/validators.js:124:11) at Object.join (path.js:1039:7) at noopServiceWorkerMiddleware (/Users/ago/progetti/github/create-elm-app/node_modules/react-dev-utils/noopServiceWorkerMiddleware.js:14:26) at Layer.handle [as handle_request] (/Users/ago/progetti/github/create-elm-app/node_modules/express/lib/router/layer.js:95:5) at trim_prefix (/Users/ago/progetti/github/create-elm-app/node_modules/express/lib/router/index.js:317:13) at /Users/ago/progetti/github/create-elm-app/node_modules/express/lib/router/index.js:284:7 at Function.process_params (/Users/ago/progetti/github/create-elm-app/node_modules/express/lib/router/index.js:335:12) at next (/Users/ago/progetti/github/create-elm-app/node_modules/express/lib/router/index.js:275:10) at launchEditorMiddleware (/Users/ago/progetti/github/create-elm-app/node_modules/react-dev-utils/errorOverlayMiddleware.js:20:7) at Layer.handle [as handle_request] (/Users/ago/progetti/github/create-elm-app/node_modules/express/lib/router/layer.js:95:5)

just checkout the project and run npm run app:start

@jlengrand
Copy link
Contributor Author

Alright @Slumber86 i've reverted the react-dev-utils change.

I see that since I created that PR, 5 more dependencies deprecations came in. If this one does not get merge soon, it will be outdated again.
I have no problem adding the extra deps in this PR (except for react-dev-utils) but it'd be nice if I could get a signal whether this is desired, welcome or worthful :).

Thanks for the help BTW!

@jlengrand
Copy link
Contributor Author

Annnnd, the build is green!

@Slumber86
Copy link
Contributor

I think we should hear from @halfzebra

@jlengrand
Copy link
Contributor Author

That's alright. I don't want to overload him either :). Is @halfzebra the only current contributor for the project?

@halfzebra halfzebra self-requested a review November 4, 2023 23:09
Copy link
Owner

@halfzebra halfzebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this, thanks for the effort, and sorry for the delay!

@halfzebra halfzebra merged commit c4de5ef into halfzebra:master Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants