Issue with combo index search parameter when using date

[epeartree]

the problem:
Given a combo index search parameters configured with a date search parameter components, combo index searching is skipped when a date query parameter value is submitted to the search stack.

root cause:
The root cause of the problem is that we default DateRangeParam.myPrefix to 'EQUAL' when parsing a query date parameter into a DateRangeParam object. More specifically, query parameter birthdate=2021-01-01 and birthdate=eq2021-01-01 would yield the same DateRangeParam object with dateRangeParam.myPrefix=EQUAL making it impossible to differentiate whether the prefix was specifically provided or not. As a result, searching the single table populated by combo index search parameters to optimise specific searches is skipped since the dateRangeParam has a prefix. see SearchBuilder.validateParamValuesAreValidForComboParam

what was done:

• Modified class DateRangeParam to not default the prefix to 'EQUAL' as doing so would make it impossible for indexes created by a combo search index parameters to be queried during searches;
• added utility method and comment to return a prefix of 'equal' when performing computation based on prefix value;
• modified tests;
• added changelog;

[github-actions]

Formatting check succeeded!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (406db33) to head (3baa480).
Report is 160 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6566      +/-   ##
============================================
- Coverage     83.54%   83.50%   -0.04%     
- Complexity    27432    28559    +1127     
============================================
  Files          1707     1797      +90     
  Lines        106185   111141    +4956     
  Branches      13397    13961     +564     
============================================
+ Hits          88710    92808    +4098     
- Misses        11750    12349     +599     
- Partials       5725     5984     +259     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmarchionatto]

Fix looks good, but there is no test for the specific point of the fix, which is that the combo search is now considered. Please add test for that case.

[jamesagnew]

I'm not sure I follow the test. If those two query strings are considered equivalent, why are we treating them differently? I guess it's because we turn this into a date range, but that logic is kinda confusing. Recommend at least adding comments here to explain what's going on with this test and why we should expect a different result for these two values.

[epeartree]

NP at all. to avoid a regression, this test and its purpose needs be crystal clear on the first read.