Skip to content

fix(security): move OpenAPI lambda image to patched Node 24 - #121

Draft
imperfect-fourth wants to merge 7 commits into
mainfrom
imperfect-fourth/emudhra-connector-tls
Draft

imperfect-fourth wants to merge 7 commits into
mainfrom
imperfect-fourth/emudhra-connector-tls

Conversation

@imperfect-fourth

@imperfect-fourth imperfect-fourth commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Move image NodeSource major from 20.x to 24.x and enforce installed Node >=24.22.1.
  • Retain fixed OS CA-package floor and explicit OS trust selection.
  • Disable native TypeScript stripping to preserve existing ts-node function loading; update obsolete pending-fix guidance.

Status — keep draft

  • @hasura/ndc-sdk-typescript 8.5.1 published (2026-10-26; pulls @grpc/grpc-js 1.14.6).
  • fix(security): require patched Node 24 runtime for lambda images ndc-nodejs-lambda#81 merged: lambda SDK on ^8.5.1, image requires Node 24 >=24.22.1.
  • Release ndc-nodejs-lambda v1.20.4 (latest published is still v1.20.3).
  • Bump NDC_NODEJS_LAMBDA_SDK_VERSION (src/app/context.ts) and connector-definition/.hasura-connector/Dockerfile from v1.20.2 to v1.20.4 in this PR.
  • Trivy (image scan) fails on 17 HIGH in generator deps: brace-expansion 5.0.5, braces 3.0.3 (no fix), js-yaml 4.1.1, nanoid 3.3.11, swagger-typescript-api 13.0.16.
  • Node 24 image smoke test against all 12 incident TLS chains plus an unrelated valid control.

Validation

  • npm ci and TypeScript compilation passed locally on Node 24.22.1. CI: unit-tests, verify-ndc-lambda-sdk-version and build-docker-image pass.
  • This generator has no direct base TypeScript SDK dependency; it writes/installs @hasura/ndc-lambda-sdk versions into generated function projects. Existing generated projects need their own lock updates.

Release boundary

Source/build-input changes only. Fresh images must be built and tested with explicit certificate-verification failures. Runtime/OS trust, custom CA overrides, derived images and deployed provenance remain separate.

Incident: https://emudhra.we-have-a-problem.com/


Update (2026-10-26)

  • Pinned ndc-nodejs-lambda v1.20.4 (context.ts + connector-definition Dockerfile); verify script passes.
  • Trivy fixes: overrides js-yaml 4.3.2, brace-expansion 5.0.12, fast-uri 3.1.9; npm's bundled undici swapped to 6.29.1 (as in ndc-nodejs-lambda).
  • .trivyignore (wired into the scan job): only braces CVE-2026-93687 (no fix upstream).
  • swagger-typescript-api 13.0.16 → 13.12.2 (name → fileName). Generated output changes, golden files regenerated: nullable request bodies are typed | null, dotted query param names (e.g. p.limit) are kept instead of camelCased, and some parser-type golden files (kubernetes, gitlab, mailchimp) shrink. Please review.
  • TLS smoke test against the incident cert chains.

All CI checks green on f7192ec.

@imperfect-fourth imperfect-fourth changed the title fix(security): select patched OS trust for OpenAPI lambda images fix(security): move OpenAPI lambda image to patched Node 24 Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant