Repository navigation
fix(security): move OpenAPI lambda image to patched Node 24 - #121
Draft
imperfect-fourth wants to merge 7 commits into
Draft
imperfect-fourth wants to merge 7 commits into
imperfect-fourth wants to merge 7 commits into
Conversation
…nanoid, brace-expansion); add .trivyignore
…rop its .trivyignore entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Status — keep draft
@hasura/ndc-sdk-typescript8.5.1 published (2026-10-26; pulls@grpc/grpc-js1.14.6).^8.5.1, image requires Node 24 >=24.22.1.ndc-nodejs-lambdav1.20.4 (latest published is still v1.20.3).NDC_NODEJS_LAMBDA_SDK_VERSION(src/app/context.ts) andconnector-definition/.hasura-connector/Dockerfilefrom v1.20.2 to v1.20.4 in this PR.Validation
@hasura/ndc-lambda-sdkversions into generated function projects. Existing generated projects need their own lock updates.Release boundary
Source/build-input changes only. Fresh images must be built and tested with explicit certificate-verification failures. Runtime/OS trust, custom CA overrides, derived images and deployed provenance remain separate.
Incident: https://emudhra.we-have-a-problem.com/
Update (2026-10-26)
ndc-nodejs-lambdav1.20.4 (context.ts+ connector-definition Dockerfile); verify script passes.js-yaml4.3.2,brace-expansion5.0.12,fast-uri3.1.9; npm's bundledundiciswapped to 6.29.1 (as in ndc-nodejs-lambda)..trivyignore(wired into the scan job): onlybracesCVE-2026-93687 (no fix upstream).swagger-typescript-api13.0.16 → 13.12.2 (name→fileName). Generated output changes, golden files regenerated: nullable request bodies are typed| null, dotted query param names (e.g.p.limit) are kept instead of camelCased, and some parser-type golden files (kubernetes, gitlab, mailchimp) shrink. Please review.All CI checks green on
f7192ec.