Check for event queue overflow in usbd / dcd_event_handler #1662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
osal_queue_send
to send events to the queue_usbd_q
inudbd.c
'sdcd_event_handler
, the queue may overflow (particularly if the application callsusbd_defer_func
too often). In that case, events will be missed, leading to spurious and hard-to-debug errors (for example, IN data is sent, ISR is called, but nothing else happens).Therefore I'd like to suggest adding
TU_ASSERT
around the calls toosal_queue_send
in order to make finding these bugs easier.