Repository navigation
Cleanup legacy version support - #5881
Open
rocket-turtle wants to merge 6 commits into
Open
rocket-turtle wants to merge 6 commits into
rocket-turtle wants to merge 6 commits into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…lpers Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
rocket-turtle
force-pushed
the
cleanup-legacy-version-support
branch
from
November 6, 2026 11:07
2e3b974 to
3538d3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the years Devise has collected a lot of compatibility code that was only there for Rails and Ruby versions that are long EOL. Rails 7.x doesn't get updates anymore, neither does Ruby 3.1. That means we were maintaining and testing code in CI that
nobody should need in practise anymore.
Concretely we:
Net result is roughly 300 lines less code with the same functionallity. The test suite passes completly on Rails 8.0 and 8.1. For everyone still on older versions the 5.0.x line stays as it is.
We kept Rails 8.0 because supporting it costs us nothing, there is no extra compat code for it, it just works. The goal was removing dead legacy code, not cutting versions that still run fine.