Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For CI with 1.7.3-namada #19

Closed
wants to merge 25 commits into from

Namada 0.29.0

b68f7b2
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

For CI with 1.7.3-namada #19

Namada 0.29.0
b68f7b2
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy-all-features failed Dec 30, 2023 in 0s

clippy-all-features

3 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 0
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check failure on line 142 in crates/relayer-types/src/core/ics23_commitment/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-all-features

accessing first element with `ics23_specs.get(0)`

error: accessing first element with `ics23_specs.get(0)`
   --> crates/relayer-types/src/core/ics23_commitment/merkle.rs:142:20
    |
142 |         let spec = ics23_specs.get(0).ok_or_else(Error::invalid_merkle_proof)?;
    |                    ^^^^^^^^^^^^^^^^^^ help: try: `ics23_specs.first()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first

Check failure on line 141 in crates/relayer-types/src/core/ics23_commitment/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-all-features

accessing first element with `self.proofs.get(0)`

error: accessing first element with `self.proofs.get(0)`
   --> crates/relayer-types/src/core/ics23_commitment/merkle.rs:141:21
    |
141 |         let proof = self.proofs.get(0).ok_or_else(Error::invalid_merkle_proof)?;
    |                     ^^^^^^^^^^^^^^^^^^ help: try: `self.proofs.first()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first

Check failure on line 104 in crates/relayer-types/src/applications/ics31_icq/events.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-all-features

accessing first element with `block_events .get(key) .ok_or_else(|| Error::event(format!("attribute not found for key: {key}")))?.get(0)`

error: accessing first element with `block_events
               .get(key)
               .ok_or_else(|| Error::event(format!("attribute not found for key: {key}")))?.get(0)`
   --> crates/relayer-types/src/applications/ics31_icq/events.rs:101:15
    |
101 |       let res = block_events
    |  _______________^
102 | |         .get(key)
103 | |         .ok_or_else(|| Error::event(format!("attribute not found for key: {key}")))?
104 | |         .get(0)
    | |_______________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
    = note: `-D clippy::get-first` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::get_first)]`
help: try
    |
101 ~     let res = block_events
102 +         .get(key)
103 +         .ok_or_else(|| Error::event(format!("attribute not found for key: {key}")))?.first()
    |