adding some comments' improvements

heliomar-pena · Dec 17, 2023 · aee5364 · aee5364
1 parent 9f162e5
commit aee5364
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/controllers/generateConfigController.js b/controllers/generateConfigController.js
@@ -6,14 +6,13 @@ const { listFilesOnDirectory } = require("../utils/listFiles");
 const { supportedLanguagesCodes } = require("../utils/supportedLanguagesUtils");
 
 const _promptTranslationEngines = () => {
-  const translationEngines = [...validEngines];
   const translationEnginesToUse = [];
 
   console.log(
     "Will ask you for the translation engines you want to use. You will be able to change them later in the configuration file."
   );
 
-  for (translationEngine of translationEngines) {
+  for (translationEngine of validEngines) {
     const shouldUseEngine = confirmUserAction(
       `Do you want to use ${translationEngine} as translation engine? (y/n): `
     );
@@ -34,7 +33,7 @@ const _promptBasePath = async () => {
   do {
     let hasError = false;
     basePath = promptUserInput(
-      'Base path for the translations files: b.e "src/localizations.": '
+      'Base path for the translations files: e.g "src/localizations.": '
     );
 
     if (!basePath) {

diff --git a/controllers/generateConfigController.test.js b/controllers/generateConfigController.test.js
@@ -106,7 +106,7 @@ describe("_promptBasePath", () => {
 
     expect(promptUserInput).toHaveBeenCalledTimes(2);
     expect(promptUserInput).toHaveBeenCalledWith(
-      'Base path for the translations files: b.e "src/localizations.": '
+      'Base path for the translations files: e.g "src/localizations.": '
       );
     expect(confirmUserAction).toHaveBeenCalledTimes(1);
 
@@ -125,7 +125,7 @@ describe("_promptBasePath", () => {
 
     expect(promptUserInput).toHaveBeenCalledTimes(3);
     expect(promptUserInput).toHaveBeenCalledWith(
-      'Base path for the translations files: b.e "src/localizations.": '
+      'Base path for the translations files: e.g "src/localizations.": '
     );
     expect(promptUserInput).toHaveBeenCalledWith(
       '\nPress enter to continue...'
@@ -153,7 +153,7 @@ describe("_promptBasePath", () => {
 
     expect(promptUserInput).toHaveBeenCalledTimes(3);
     expect(promptUserInput).toHaveBeenCalledWith(
-      'Base path for the translations files: b.e "src/localizations.": '
+      'Base path for the translations files: e.g "src/localizations.": '
     );
 
     expect(listFilesOnDirectory).toHaveBeenCalledTimes(2);
@@ -183,7 +183,7 @@ describe("_promptBasePath", () => {
 
     expect(promptUserInput).toHaveBeenCalledTimes(4);
     expect(promptUserInput).toHaveBeenCalledWith(
-      'Base path for the translations files: b.e "src/localizations.": '
+      'Base path for the translations files: e.g "src/localizations.": '
     );
 
     expect(listFilesOnDirectory).toHaveBeenCalledTimes(3);

diff --git a/utils/listFiles.js b/utils/listFiles.js
@@ -17,4 +17,4 @@ const listFilesOnDirectory = (directory) => {
     });
 };
 
-module.exports = { listFilesOnDirectory }
+module.exports = { listFilesOnDirectory }
diff --git a/utils/supportedLanguagesUtils.js b/utils/supportedLanguagesUtils.js
@@ -15,7 +15,7 @@ const supportedLanguages = Object.keys(allLanguagesCodes).reduce((acc, language)
 
 /**
  * An array containing all the supported languages without extra data as language name or supported engines. Only the language code.
- * b.e ['en', 'es', 'pt', ...]
+ * e.g ['en', 'es', 'pt', ...]
  */
 const supportedLanguagesCodes = Object.keys(supportedLanguages);
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,4 +17,4 @@ const listFilesOnDirectory = (directory) => { @@
         });
     };
-    module.exports = { listFilesOnDirectory }
+    module.exports = { listFilesOnDirectory }