Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include device type in mobile gateway info #688

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Conversation

jeffgrunewald
Copy link
Contributor

No description provided.

@andymck
Copy link
Contributor

andymck commented Dec 14, 2023

why the dup pr, when there is #632 ( albeit requiring updating )?

@jeffgrunewald
Copy link
Contributor Author

why the dup pr, when there is #632 ( albeit requiring updating )?

This is a pressing need for the app team (builder app needs the data) but @bbalser said we need to reevaluate the logic of the asserted location distance check in addition to the rebase so I wanted to get this change in independently.

@andymck
Copy link
Contributor

andymck commented Dec 14, 2023

why the dup pr, when there is #632 ( albeit requiring updating )?

This is a pressing need for the app team (builder app needs the data) but @bbalser said we need to reevaluate the logic of the asserted location distance check in addition to the rebase so I wanted to get this change in independently.

gotcha

mobile_config/src/gateway_info.rs Show resolved Hide resolved
@jeffgrunewald jeffgrunewald merged commit 86c7479 into main Dec 14, 2023
1 check passed
@jeffgrunewald jeffgrunewald deleted the jg/mobile-device-type branch December 14, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants