Skip to content

Commit

Permalink
Gap fill tool tip clarification & filter_out_gap_fill setting visibil…
Browse files Browse the repository at this point in the history
…ity (SoftFever#6468)

* Gap fill tool tip clarification

* Gap fill text and parameter visibility update
  • Loading branch information
igiannakas authored Aug 18, 2024
1 parent 364d91b commit 01b1681
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 10 deletions.
21 changes: 16 additions & 5 deletions src/libslic3r/PrintConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -817,12 +817,22 @@ void PrintConfigDef::init_fff_params()
def = this->add("gap_fill_target", coEnum);
def->label = L("Apply gap fill");
def->category = L("Strength");
def->tooltip = L("Enables gap fill for the selected surfaces. The minimum gap length that will be filled can be controlled "
def->tooltip = L("Enables gap fill for the selected solid surfaces. The minimum gap length that will be filled can be controlled "
"from the filter out tiny gaps option below.\n\n"
"Options:\n"
"1. Everywhere: Applies gap fill to top, bottom and internal solid surfaces\n"
"2. Top and Bottom surfaces: Applies gap fill to top and bottom surfaces only\n"
"3. Nowhere: Disables gap fill\n");
"1. Everywhere: Applies gap fill to top, bottom and internal solid surfaces for maximum strength\n"
"2. Top and Bottom surfaces: Applies gap fill to top and bottom surfaces only, balancing print speed, "
"reducing potential over extrusion in the solid infill and making sure the top and bottom surfaces have "
"no pin hole gaps\n"
"3. Nowhere: Disables gap fill for all solid infill areas. \n\n"
"Note that if using the classic perimeter generator, gap fill may also be generated between perimeters, "
"if a full width line cannot fit between them. That perimeter gap fill is not controlled by this setting. \n\n"
"If you would like all gap fill, including the classic perimeter generated one, removed, "
"set the filter out tiny gaps value to a large number, like 999999. \n\n"
"However this is not advised, as gap fill between perimeters is contributing to the model's strength. "
"For models where excessive gap fill is generated between perimeters, a better option would be to "
"switch to the arachne wall generator and use this option to control whether the cosmetic top and "
"bottom surface gap fill is generated");
def->enum_keys_map = &ConfigOptionEnum<GapFillTarget>::get_enum_values();
def->enum_values.push_back("everywhere");
def->enum_values.push_back("topbottom");
Expand Down Expand Up @@ -2539,7 +2549,8 @@ void PrintConfigDef::init_fff_params()
def = this->add("filter_out_gap_fill", coFloat);
def->label = L("Filter out tiny gaps");
def->category = L("Layers and Perimeters");
def->tooltip = L("Filter out gaps smaller than the threshold specified");
def->tooltip = L("Don't print gap fill with a length is smaller than the threshold specified (in mm). This setting applies to top, "
"bottom and solid infill and, if using the classic perimeter generator, to wall gap fill. ");
def->sidetext = L("mm");
def->mode = comAdvanced;
def->set_default_value(new ConfigOptionFloat(0));
Expand Down
5 changes: 0 additions & 5 deletions src/slic3r/GUI/ConfigManipulation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -515,11 +515,6 @@ void ConfigManipulation::toggle_print_fff_options(DynamicPrintConfig *config, co
apply(config, &new_conf);
}

// Orca: Hide the filter out tiny gaps field when gap fill target is nowhere as no gap fill will be applied.
bool have_gap_fill = config->opt_enum<GapFillTarget>("gap_fill_target") != gftNowhere;
toggle_line("filter_out_gap_fill", have_gap_fill);


bool have_perimeters = config->opt_int("wall_loops") > 0;
for (auto el : { "extra_perimeters_on_overhangs", "ensure_vertical_shell_thickness", "detect_thin_wall", "detect_overhang_wall",
"seam_position", "staggered_inner_seams", "wall_sequence", "outer_wall_line_width",
Expand Down

0 comments on commit 01b1681

Please sign in to comment.