Repository navigation
CASL-1939 improve authorization checks - #669
Merged
Merged
Conversation
Marcin-Here
requested changes
Sep 17, 2026
Marcin-Here
left a comment
Marcin-Here
left a comment
Contributor
There was a problem hiding this comment.
- Build fails, not all test passes let's fix that first
- Let's take a look at original ticket I think not all changes from both v2 PRs were ported
- Also on GitHub PR's we need to add DCO (which is also checked) https://github.com/apps/dco
- Let's fix above issues before continue with review.
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Code Coverage
|
kacper-kozera
force-pushed
the
v3_CASL-1939
branch
from
September 21, 2026 10:33
3a4011d to
a346c96
Compare
Code Coverage
|
Marcin-Here
requested changes
Sep 22, 2026
| "description": "Storage payload for write authorization negative test", | ||
| "className": "naksha.psql.PsqlStorage", | ||
| "properties": { | ||
| "dbConfig": { |
Contributor
There was a problem hiding this comment.
In v3 correct from for connection would be top level master:{"host":...., "db":... } not properties.dbConfig
| "description": "PSQL storage instance for testing purpose - PUT auth denial", | ||
| "className": "naksha.psql.PsqlStorage", | ||
| "properties": { | ||
| "dbConfig": { |
Contributor
There was a problem hiding this comment.
In v3 correct from for connection would be top level master:{"host":...., "db":... } not properties.dbConfig
| package com.here.naksha.lib.handlers; | ||
|
|
||
| import static com.here.naksha.lib.handlers.AbstractEventHandler.EventProcessingStrategy.SEND_UPSTREAM_WITHOUT_PROCESSING; | ||
| import static com.here.naksha.lib.handlers.AbstractEventHandler.EventProcessingStrategy.*; |
Contributor
There was a problem hiding this comment.
As discussed before, we should avoid * imports.
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Code Coverage
|
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Code Coverage
|
Marcin-Here
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.