test: only print stderr logs within test output boundaries - #1492
Merged
Merged
Conversation
Instead of printing the logs whenever they happen, this collect the logs in the test output, and is printed when the test result is printed. This way we know which output belongs to which test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
=======================================
Coverage 72.81% 72.81%
=======================================
Files 302 302
Lines 11177 11177
=======================================
Hits 8138 8138
Misses 2141 2141
Partials 898 898
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
phm07
approved these changes
Sep 24, 2026
phm07
left a comment
Contributor
There was a problem hiding this comment.
Nice, that was an easy fix 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of printing the logs whenever they happen, this collect the logs in the test output, and is printed when the test result is printed.
This way we know which output belongs to which test.