Skip to content

fix(primary-ip): add fallback for unknown assignee types - #1493

Merged
phm07 merged 1 commit into
mainfrom
primary-ip-assignee-fallback
Sep 24, 2026
Merged

phm07 merged 1 commit into
mainfrom
primary-ip-assignee-fallback

Conversation

@phm07

@phm07 phm07 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@phm07 phm07 self-assigned this Sep 24, 2026
@phm07
phm07 requested a review from a team as a code owner September 24, 2026 13:12
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.78%. Comparing base (84e2b7c) to head (b7d003a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/primaryip/list.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   72.81%   72.78%   -0.03%     
==========================================
  Files         302      302              
  Lines       11177    11181       +4     
==========================================
  Hits         8138     8138              
- Misses       2141     2145       +4     
  Partials      898      898              
Flag Coverage Δ
e2e 51.22% <0.00%> (-0.01%) ⬇️
unit 67.68% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07
phm07 merged commit 0856baa into main Sep 24, 2026
8 checks passed
@phm07
phm07 deleted the primary-ip-assignee-fallback branch September 24, 2026 13:21
jooola pushed a commit that referenced this pull request Sep 24, 2026
<!-- section-start changelog -->
### Features

- **network**: implement list-members command (#1491)
([d4e3726](d4e3726))

### Bug Fixes

- **primary-ip**: add fallback for unknown assignee types (#1493)
([0856baa](0856baa))

<!-- section-end changelog -->

---

<details>
<summary><h4>PR by <a
href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a>
🤖</h4></summary>

If you want to modify the proposed release, add you overrides here. You
can learn more about the options in the docs.

## Release Notes

### Prefix / Start

This will be added to the start of the release notes.

~~~~rp-prefix
~~~~

### Suffix / End

This will be added to the end of the release notes.

~~~~rp-suffix
~~~~

</details>

Co-authored-by: Hetzner Cloud Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants