DMP-4316: fix default sorting on tables on admin portal #2412
Conversation
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2412
labels
Ben-Edwards-cgi
requested review from
davet1985,
jackmaloney,
cakeben,
c4seyla,
adulkoan-hmcts and
jyothi-balla
and removed request for
a team
| @@ -244,8 +251,13 @@ public List<AdminCasesSearchResponseItem> adminCaseSearch(AdminCasesSearchReques | |||
| if (matchingCaseIds.size() > adminSearchMaxResults) { | |||
| throw new DartsApiException(CaseApiError.TOO_MANY_RESULTS); | |||
| } | |||
| List<CourtCaseEntity> matchingCases = caseRepository.findAllById(matchingCaseIds); | |||
| hearingRepository.findByCaseIds(matchingCaseIds); | |||
| List<CourtCaseEntity> matchingCases = caseRepository.findAll(new Specification<CourtCaseEntity>() { | |||
There was a problem hiding this comment.
Shouldn't this be a specific database call to get the matching cases by the order by name
There was a problem hiding this comment.
As this is only used here i stuck it in the service but it does make more sense to be in the repository layer as we are not doing any dynamic filters.
Will move :)
|
|
||
| for (int i = 0; i < events.size(); i++) { | ||
| EventMapping event = events.get(i); | ||
| System.out.println(".andExpect(jsonPath(\"$[" + i + "].name\", Matchers.is(\"" + event.getName() + "\")))"); |
There was a problem hiding this comment.
System.out in production code?
There was a problem hiding this comment.
This was left over from some testing good spot will remove :)
|
|
||
| ///admin/retention-policy-types |
There was a problem hiding this comment.
Too many dashes for comment?
There was a problem hiding this comment.
I have removed this comment as it does not provide any real value :)
| WHERE cc.id in :ids | ||
| ORDER BY cc.id DESC | ||
| """) | ||
| List<CourtCaseEntity> findAllWithIdMatchingOneOf(List<Integer> ids); |
There was a problem hiding this comment.
You have added this new method to the repository so you need to have an integration repository test for this.
| @@ -13,7 +14,8 @@ | |||
| @Repository | |||
| public interface RetentionPolicyTypeRepository extends | |||
| RevisionRepository<RetentionPolicyTypeEntity, Integer, Long>, | |||
| JpaRepository<RetentionPolicyTypeEntity, Integer> { | |||
| JpaRepository<RetentionPolicyTypeEntity, Integer>, | |||
| JpaSpecificationExecutor<RetentionPolicyTypeEntity> { | |||
There was a problem hiding this comment.
You have added JpaSpecificationExecutor without using it. Is this necessary?
Ben-Edwards-cgi
force-pushed
the
DMP-4316
branch
from
5a0feab to
adaa648
Compare
Links
Change description
The tables on admin portal are not sorted by a particular field by default and just return the results as the database returns them.
The following tables need sorting as specified:
** Audio: Hearings date & Channel - [~leanne.jacobs] to move to another ticket following screen redesign
** {color:#00875a}Transcripts: CaseID{color}
All sorted descending
Acceptance criteria
Each table as listed above sorts by default by the attribute labelled after the colon :
Does this PR introduce a breaking change? (check one with "x")