Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUB-2638 - Remove OPA lists #1377

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

PUB-2638 - Remove OPA lists #1377

wants to merge 17 commits into from

Conversation

NatashaAlker
Copy link
Contributor

JIRA link

https://tools.hmcts.net/jira/browse/PUB-2638

Change description

Remove OPA lists

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

Copy link
Contributor

@junaidiqbalmoj junaidiqbalmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There is a file listlookup.json which has OPA list information in it. That's needs to be removed otherwise OPA lists will be shown on list type subscription.
  2. There are some tests for subscription-config-list view which are checking OPA lists, these tests need to be updated as well.

@NatashaAlker
Copy link
Contributor Author

  1. There is a file listlookup.json which has OPA list information in it. That's needs to be removed otherwise OPA lists will be shown on list type subscription.
  2. There are some tests for subscription-config-list view which are checking OPA lists, these tests need to be updated as well.

Removed, thanks! :)

Copy link

sonarqubecloud bot commented Nov 4, 2024

KianKwa
KianKwa previously approved these changes Nov 5, 2024
@ChrisS1512 ChrisS1512 changed the base branch from master to freeze November 14, 2024 15:36
Base automatically changed from freeze to master November 29, 2024 09:26
@ChrisS1512 ChrisS1512 dismissed KianKwa’s stale review November 29, 2024 09:26

The base branch was changed.

@ChrisS1512 ChrisS1512 changed the base branch from master to freeze December 19, 2024 15:40
@hmcts-jenkins-cnp hmcts-jenkins-cnp bot requested a deployment to preview December 31, 2024 09:06 Abandoned
@ChrisS1512 ChrisS1512 changed the base branch from freeze to master January 6, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants