fix(PRL-6716-build-issue): Fix build issue (#1715)

package.json

@@ -53,7 +53,7 @@
     "@types/cookie-parser": "^1.4.2",
     "@types/csurf": "^1.11.2",
     "@types/es6-promisify": "^6.0.1",
-    "@types/express": "^4.17.21",
+    "@types/express": "^5.0.0",
     "@types/express-session": "^1.17.4",
     "@types/glob": "^8.0.0",
     "@types/lodash": "^4.14.186",
@@ -81,7 +81,7 @@
     "csurf": "^1.11.0",
     "dayjs": "^1.10.7",
     "email-validator": "^2.0.4",
-    "express": "^4.19.2",
+    "express": "^4.21.1",
     "express-fileupload": "^1.4.0",
     "express-http-proxy": "^1.6.3",
     "express-nunjucks": "^2.2.5",
@@ -211,7 +211,8 @@
     "ws": "^8.18.0",
     "semver": "^7.5.4",
     "send": "0.19.0",
-    "serve-static": "1.16.2"
+    "serve-static": "1.16.2",
+    "cross-spawn": "7.0.6"
   },
   "packageManager": "[email protected]"
 }

src/main/modules/error-handler/index.ts

@@ -34,12 +34,12 @@ export class ErrorHandler {
   }
 
   public handleNextErrorsFor(app: Application): void {
-    app.use((err: Error | string | undefined, req: Request, res: Response, next: NextFunction) => {
+    app.use((err: Error | string | undefined, req: Request, res: Response, next: NextFunction): void => {
       if (err) {
-        // change
-        return err;
+        res.status(500).send('Internal Server Error');
+      } else {
+        next();
       }
-      next();
     });
   }
 }

src/main/modules/i18n/index.ts

@@ -17,7 +17,8 @@ export class LanguageToggle {
 
         if (LanguageToggle.supportedLanguages.includes(requestedLanguage)) {
           req.session['lang'] = requestedLanguage;
-          return req.session.save(next);
+          req.session.save(next);
+          return;
         }
       }
       next();

yarn-audit-known-issues

@@ -1 +1 @@
-{"actions":[],"advisories":{},"muted":[],"metadata":{"vulnerabilities":{"info":0,"low":0,"moderate":0,"high":0,"critical":0},"dependencies":720,"devDependencies":1,"optionalDependencies":0,"totalDependencies":721}}
+{"actions":[],"advisories":{},"muted":[],"metadata":{"vulnerabilities":{"info":0,"low":0,"moderate":0,"high":0,"critical":0},"dependencies":721,"devDependencies":1,"optionalDependencies":0,"totalDependencies":722}}