Dockerize maven install #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified builds by introducing Maven-based multi-stage builds, consolidating dependencies, and reducing image sizes. Updated entry points to ensure runtime efficiency and maintainability. Transitioned from `ADD` to `COPY` for better clarity and consistency.
Updated COPY commands in Dockerfiles to use a relative path specific to the current directory. This change ensures cleaner and more accurate file copying during container builds.
Updated Dockerfiles to leverage an existing image for Maven dependencies, reducing redundant downloads and speeding up builds. Introduced a multi-stage build process to improve efficiency and maintain consistency across projects."
Both Dockerfiles now reference the LATEST tag instead of a specific commit for the `hms-dbmi/pic-sure-api` image. This ensures the build process uses the most up-to-date base image available.
Unnecessary comments and stage labels were removed to streamline the Dockerfiles for `pic-sure-hpds-etl` and `pic-sure-hpds`. This cleanup improves readability and reduces clutter without altering functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.