Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate svc accounts for raw-data-api and fmtm #1529

Merged
merged 5 commits into from
May 20, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to #1497

Describe this PR

  • This is a temp solution.
  • Separates service account tokens for raw-data-api data extract generation and FMTM temporary auth.
  • Two variables: RAW_DATA_API_AUTH_TOKEN and OSM_SVC_ACCOUNT_TOKEN.
  • In future we may remove the temp auth OSM_SVC_ACCOUNT_TOKEN and replace with a JWT-based auth.

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added the backend Related to backend code label May 20, 2024
@spwoodcock spwoodcock requested a review from Sujanadh May 20, 2024 16:46
@spwoodcock spwoodcock self-assigned this May 20, 2024
@spwoodcock spwoodcock merged commit f87ead7 into development May 20, 2024
5 checks passed
@spwoodcock spwoodcock deleted the build/separate-svc-accounts branch May 20, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants