Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customTable): classname add #1578

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR fix the table header actions not being fixed.

Screenshots

image

@github-actions github-actions bot added the frontend Related to frontend code label Jun 16, 2024
@spwoodcock
Copy link
Member

Nice debugging!! That was a well hidden one - apologies πŸ˜…

Could you possibly remove the edit to package.json with the packageManager set?
I think this is required after updates to corepack, so I will look into setting the var in another PR.

Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@spwoodcock
Copy link
Member

Actually, the version specified is probably fine after researching further.

Corepack works by downloading the specified version and proxying the binary anyway, so this shouldn't cause issues anywhere.

Fixes #1579

@spwoodcock spwoodcock self-requested a review June 16, 2024 11:07
@spwoodcock spwoodcock merged commit 1b15e44 into hotosm:development Jun 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants