Skip to content

chore(configs): migrate legacy faraday strategy declarations to default and update specs #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gildesmarais merged 1 commit into from
Sep 6, 2026
Merged

chore(configs): migrate legacy faraday strategy declarations to default and update specs #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/html2rss/configs/canada.ca/en_stories.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ selectors:
items:
selector: main > section > div > article > div > div > div
enhance: true
strategy: faraday
1 change: 0 additions & 1 deletion lib/html2rss/configs/ecologie.gouv.fr/presse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ selectors:
items:
selector: div.fr-col
enhance: true
strategy: faraday
1 change: 0 additions & 1 deletion lib/html2rss/configs/forskningsradet.no/en_news.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ selectors:
items:
selector: main > div > div > div
enhance: true
strategy: faraday
1 change: 0 additions & 1 deletion lib/html2rss/configs/parks.vic.gov.au/news.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ selectors:
items:
selector: div.col-sm-10
enhance: true
strategy: faraday
1 change: 0 additions & 1 deletion lib/html2rss/configs/standards.org.au/news.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ selectors:
items:
selector: div.articles-text-div
enhance: true
strategy: faraday
1 change: 0 additions & 1 deletion lib/html2rss/configs/unep-wcmc.org/en_news.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ selectors:
items:
selector: li.listing-grid__item
enhance: true
strategy: faraday
2 changes: 2 additions & 0 deletions spec/support/botasaurus_fetch_configs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ module BotasaurusFetchConfigs
chathamhouse.org/research-publications.yml
curia.europa.eu/press-releases.yml
ethz.ch/eth-news.yml
hkma.gov.hk/eng_news-and-media_press-releases.yml
iiss.org/online-analysis.yml
imdb.com/ratings.yml
imo.org/press-briefings.yml
ndl.go.jp/en_news.yml
ntu.edu.sg/news.yml
occrp.org/news.yml
oecd.org/newsroom.yml
Expand Down
5 changes: 2 additions & 3 deletions spec/support/shared_examples/config.yml_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,8 @@

context 'with selectors present' do
it 'has required selectors', :aggregate_failures do
%w[items title].each do |required_attribute|
expect(yaml['selectors'][required_attribute]).not_to(be_empty, required_attribute)
end
expect(yaml['selectors']['items']).not_to be_empty
expect(yaml['selectors']['title']).not_to be_empty unless yaml.dig('selectors', 'items', 'enhance')
end

context 'with template post_processor' do
Expand Down
Loading