Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUI updates for HRA v2.2 (8th Release) #811

Merged
merged 101 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
101 commits
Select commit Hold shift + click to select a range
b10506e
Add violin plots by type
edlu77 Sep 4, 2024
2bbde02
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 4, 2024
2735824
Improvements to violin plot
edlu77 Sep 7, 2024
2dc2bfb
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 7, 2024
39e1c5b
Update violin plot upload settings
edlu77 Sep 9, 2024
9763cab
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 10, 2024
42c49ca
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 11, 2024
6c03588
Improvements
edlu77 Sep 13, 2024
4008e08
Refactor visualizations
edlu77 Sep 13, 2024
d3d6408
Testing
edlu77 Sep 16, 2024
5c160c4
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 16, 2024
8c553e4
Upload Data module updates
edlu77 Sep 16, 2024
4133446
Upload Data style updates
edlu77 Sep 17, 2024
d9ccc53
Add column header checking
edlu77 Sep 19, 2024
c731af2
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 19, 2024
ea6ab7f
Add configure parameters card + styling updates
edlu77 Sep 20, 2024
f7d20db
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 20, 2024
35ba554
Color map selection updates
edlu77 Sep 23, 2024
8148d39
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 23, 2024
75a0e70
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
edlu77 Sep 23, 2024
6c357b3
Fix validation of inputs
edlu77 Sep 24, 2024
b079458
Move column header errors to step 2; styling improvements
edlu77 Sep 25, 2024
9a7c6cb
Remove unused code
edlu77 Sep 25, 2024
11bce18
Set headers in submitted data to selected values
edlu77 Sep 25, 2024
f1bc2cd
Fix cell types check
edlu77 Sep 26, 2024
74dea92
Fix broken tests
edlu77 Sep 26, 2024
a51d185
Increase testing and doc coverage
edlu77 Sep 26, 2024
ec74e77
Fix test
edlu77 Sep 27, 2024
9623aa5
Fix sonarcloud issues
edlu77 Sep 27, 2024
fb919c2
Add ontologyId to submitted data
edlu77 Sep 27, 2024
75fc4b3
Add unified letter casing for headers; add headers to edge csv file d…
edlu77 Sep 27, 2024
df551b3
Renaming and tweaks
edlu77 Sep 27, 2024
e99f062
Renaming
edlu77 Sep 27, 2024
03d1f50
Set up design system theming
edlu77 Sep 27, 2024
7b5e71d
update cell type component
bhushankhope Sep 30, 2024
0a647d0
Merge branch 'develop' into cell-type-module-mvp2
bhushankhope Sep 30, 2024
df3ebb0
update path of main in cde lib project.json
bhushankhope Sep 30, 2024
0b18a78
update theme
bhushankhope Sep 30, 2024
9406c56
Change create vis page styles to use design system
edlu77 Oct 1, 2024
60dac6a
add links count to cell type table
bhushankhope Oct 1, 2024
7a7cc08
More style updates
edlu77 Oct 1, 2024
6422ebf
Make styles closer to spec
edlu77 Oct 2, 2024
8c34da1
Remove redundant assets
edlu77 Oct 2, 2024
9447f60
add toggle links column functionality
bhushankhope Oct 2, 2024
1b6778a
compute columns based on the links visibility signal
bhushankhope Oct 2, 2024
e5a30fa
Merge branch 'develop' into cell-type-module-mvp2
bhushankhope Oct 2, 2024
d570345
fix toggle signal for cell links
bhushankhope Oct 2, 2024
73bb515
Merge pull request #693 from hubmapconsortium/cde-violin-plot
axdanbol Oct 2, 2024
b1b9df9
fix tests for downloads
bhushankhope Oct 2, 2024
24f1fa6
Merge branch 'develop' into cell-type-module-mvp2
bhushankhope Oct 2, 2024
c6e1921
Merge branch 'cde-mvp2' of https://github.com/hubmapconsortium/hra-ui…
bhushankhope Oct 2, 2024
b220efc
Merge branch 'cde-mvp2' of https://github.com/hubmapconsortium/hra-ui…
edlu77 Oct 2, 2024
457b4a4
update snackbar timer
bhushankhope Oct 2, 2024
43c4ba3
add noreferrer to link
bhushankhope Oct 2, 2024
49e7c43
add micro tooltip to cell types module
bhushankhope Oct 8, 2024
0c69768
update padding and selected color for button toggle
bhushankhope Oct 10, 2024
ec8d5f9
Merge pull request #735 from hubmapconsortium/cde-create-vis-app-mvp2
axdanbol Oct 15, 2024
12914da
Merge branch 'cde-mvp2' into cell-type-module-mvp2
axdanbol Oct 15, 2024
521d77b
Merge pull request #750 from hubmapconsortium/cell-type-module-mvp2
axdanbol Oct 15, 2024
986c99d
Merge branch 'cde-mvp2' of https://github.com/hubmapconsortium/hra-ui…
edlu77 Oct 16, 2024
fabdf10
Rename edge headers
edlu77 Oct 16, 2024
3bddd97
Remove lodash
edlu77 Oct 16, 2024
820bc63
Merge pull request #742 from hubmapconsortium/cde-csv-download-update
axdanbol Oct 17, 2024
853dbec
create expansion panel
bhushankhope Oct 17, 2024
0d57bac
Merge branch 'develop' into cde-mvp2
axdanbol Oct 18, 2024
9a2283c
add animation to expansion panel
bhushankhope Oct 18, 2024
eede495
update peer deps
bhushankhope Oct 18, 2024
465e119
improve test coverage
bhushankhope Oct 22, 2024
5bbbe9a
add height check in tests for expansion panel
bhushankhope Oct 22, 2024
74e8a30
update icon button size and styles in the design system
bhushankhope Oct 22, 2024
4f311b6
update design file in the icon button stories
bhushankhope Oct 22, 2024
ff67556
Merge pull request #785 from hubmapconsortium/update-icon-button-story
axdanbol Oct 22, 2024
6626b8a
refactor animation code
bhushankhope Oct 23, 2024
614eaf6
Merge pull request #783 from hubmapconsortium/create-expansion-panel
axdanbol Oct 23, 2024
f24b335
Cde nav header updates (#778)
edlu77 Oct 23, 2024
75bf715
Node dist vis (#758)
bhushankhope Oct 24, 2024
291c227
Remove size option and adjust spacing in breadcrumbs (#789)
edlu77 Oct 25, 2024
67db439
Cde design system (#773)
edlu77 Oct 25, 2024
624ecb2
Create info modal component with two variants (#794)
edlu77 Oct 29, 2024
35d96b0
Design system menu updates (#793)
edlu77 Oct 29, 2024
6575d83
Build improvements (#796)
axdanbol Oct 30, 2024
7219467
Update styles for tree nodes and buttons (#797)
edlu77 Nov 1, 2024
9d5e79f
Cde improvements (#799)
edlu77 Nov 1, 2024
3a75cd6
Fix HRA logo width in header (Firefox)
edlu77 Nov 1, 2024
8a39b5d
update metadata, histogram, visualization, violin plot modules compon…
bhushankhope Nov 1, 2024
1a0298b
Update text field appearance (#802)
edlu77 Nov 5, 2024
6215df0
Hra rui update 2 (#807)
bhushankhope Nov 13, 2024
72edf7d
Rui registration modal r7 (#809)
edlu77 Nov 22, 2024
797faa6
Merge branch 'develop' of https://github.com/hubmapconsortium/hra-ui …
axdanbol Dec 6, 2024
67ef236
chore: Regenerate package-lock
axdanbol Dec 6, 2024
c7bd2ff
fix:
axdanbol Dec 6, 2024
a0239b8
test(cde-visualization): Fix tests mangled by merge
axdanbol Dec 6, 2024
ddf077e
refactor: Fix more merge issues
axdanbol Dec 6, 2024
d507cba
Rui update application r8 (#832)
edlu77 Dec 9, 2024
6918bff
Rui update review and download modal (#849)
edlu77 Dec 12, 2024
c573936
Add tooltips to page (#853)
edlu77 Dec 12, 2024
3ab02c5
Rui metadata registration form (#857)
axdanbol Dec 12, 2024
0b6c183
Updated logic to handle when we have newer versions of HRA v2.0+ refe…
bherr2 Dec 12, 2024
9ba7a55
Rui tweaks & bug fixes (#862)
axdanbol Dec 13, 2024
854b82b
refactor(design-system): Rename workflow card components
axdanbol Dec 13, 2024
33be557
Merge remote-tracking branch 'origin/develop' into hra-r7-rui
axdanbol Dec 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,7 @@
"body-ui",
"eui",
"node-dist-vis",
"lib:common"
],
"workbench.colorCustomizations": {
"activityBar.activeBackground": "#FF0043",
"activityBar.background": "#FF0043",
"activityBar.foreground": "#e7e7e7",
"activityBar.inactiveForeground": "#e7e7e799",
"activityBarBadge.background": "#0c5411",
"activityBarBadge.foreground": "#e7e7e7",
"sash.hoverBorder": "#FF0043",
"statusBar.background": "#B20A2F",
"statusBar.foreground": "#e7e7e7",
"statusBarItem.hoverBackground": "#FF0043",
"statusBarItem.remoteBackground": "#B20A2F",
"statusBarItem.remoteForeground": "#e7e7e7"
},
"peacock.remoteColor": "#B20A2F"
"lib:common",
"ccf-rui"
]
}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ For detailed information, please refer to the documentation for each app.
- [CCF Body UI Web Component](./apps/ccf-body-ui-wc/README.md) - A web component used in Exploration User Interface.
- [Exploration User Interface](./apps/ccf-eui/README.md) - An interactive tool for exploring and validating spatially registered tissue blocks and cell-type populations.
- [CCF Organ Info](./apps/ccf-organ-info/README.md) - User Interface for Organ Information.
- [Registration User Interfce](./apps/ccf-rui/README.md) - An interactive tool for registering tissue blocks spatially and annotating them semantically using ASCT+B Table terms.
- [Registration User Interface](./apps/ccf-rui/README.md) - An interactive tool for registering tissue blocks spatially and annotating them semantically using ASCT+B Table terms.
- [Cell Distance Explorer](./apps/cde-ui/README.md) - Compute, visualize, and explore distance distributions between different cells, cell types, anatomical structures, and more.
- [Cell Distance Explorer Visualization Web Component](./apps/cde-visualization-wc/README.md) - A web component used in Cell Distance Explorer.
- [HRA Dashboards](./apps/dashboard-ui/README.md) - Explore usage statistics of atlas data and code.
Expand Down
1 change: 1 addition & 0 deletions apps/ccf-eui/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ export class AppComponent implements OnInit {
snackBar.dismiss();
},
},
panelClass: 'usage-snackbar',
duration: this.consentService.consent === 'not-set' ? Infinity : 3000,
});

Expand Down
26 changes: 26 additions & 0 deletions apps/ccf-eui/src/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,29 @@ button {
border-style: solid;
border-radius: 0.25rem;
}

.usage-snackbar {
// Use this when design system is implemented
// --mdc-snackbar-container-color: var(--sys-surface-dim);
// --mdc-snackbar-supporting-text-color: var(--sys-secondary);

color: rgba(255, 255, 255, 0.7);
background: #323232;
box-shadow:
0px 3px 5px -1px rgba(0, 0, 0, 0.2),
0px 6px 10px 0px rgba(0, 0, 0, 0.14),
0px 1px 18px 0px rgba(0, 0, 0, 0.12);
z-index: 9999;

p {
margin: 24px;
}

button {
margin: 1rem;
min-width: 6rem;
background-color: #007cbe;
display: flex;
justify-content: center;
}
}
3 changes: 0 additions & 3 deletions apps/ccf-eui/src/themes/common/_theming.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
@use '../../app/shared/components/spatial-search-ui/spatial-search-ui.component.theme' as spatialSearchUi;
@use '../../app/shared/components/tissue-block-list/tissue-block-list.component.theme' as tissueBlockList;
@use '../../app/shared/components/term-occurence-list/term-occurrence.component.theme.scss' as termOccurrenceList;
@use '../../../../../libs/ccf-shared/src/lib//components/spatial-search-keyboard-ui/spatial-search-keyboard-ui.component.theme'
as spatialSearchKeyboardUi;
@use '../../app/shared/components/spinner-overlay/spinner-overlay.theme' as spinner;
@use '../../app/shared/components/thumbnail-carousel/thumbnail-carousel.theme' as thumbnailCarousel;
@use '../../app/modules/ontology-exploration/ontology-exploration.theme' as ontologyExploration;
Expand Down Expand Up @@ -50,7 +48,6 @@
@include spatialSearchUi.theme($theme);
@include tissueBlockList.theme($theme);
@include termOccurrenceList.theme($theme);
@include spatialSearchKeyboardUi.theme($theme);
@include spinner.theme($theme);
@include thumbnailCarousel.theme($theme);
@include filters.theme($theme);
Expand Down
93 changes: 44 additions & 49 deletions apps/ccf-rui/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,37 @@
},
"targets": {
"build": {
"executor": "@angular-devkit/build-angular:browser",
"executor": "@nx/angular:application",
"outputs": ["{options.outputPath.base}"],
"options": {
"outputPath": "dist/apps/ccf-rui",
"outputPath": {
"base": "dist/apps/ccf-rui",
"browser": "."
},
"index": "apps/ccf-rui/src/index.html",
"main": "apps/ccf-rui/src/main.ts",
"polyfills": "apps/ccf-rui/src/polyfills.ts",
"browser": "apps/ccf-rui/src/main.ts",
"polyfills": ["zone.js"],
"tsConfig": "apps/ccf-rui/tsconfig.app.json",
"assets": ["apps/ccf-rui/src/favicon.png", "apps/ccf-rui/src/assets"],
"assets": [
"apps/ccf-rui/src/favicon.png",
"apps/ccf-rui/src/assets",
{
"input": "libs/design-system/assets",
"glob": "**/*",
"output": "./assets"
}
],
"styles": ["apps/ccf-rui/src/styles.scss"],
"stylePreprocessorOptions": {
"includePaths": ["node_modules/", "libs/design-system/styles"]
},
"scripts": [],
"vendorChunk": true,
"extractLicenses": false,
"buildOptimizer": false,
"sourceMap": true,
"optimization": false,
"namedChunks": true
"define": {
"define": "undefined"
},
"outputHashing": "none",
"allowedCommonJsDependencies": ["*"],
"plugins": ["tools/esbuild-plugins/disable-code-splitting.mjs"]
},
"configurations": {
"production": {
Expand All @@ -41,13 +56,6 @@
"with": "apps/ccf-rui/src/environments/environment.prod.ts"
}
],
"optimization": true,
"outputHashing": "none",
"sourceMap": false,
"namedChunks": false,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
"budgets": [
{
"type": "initial",
Expand All @@ -61,59 +69,43 @@
}
]
},
"development": {
"baseHref": "/",
"optimization": false,
"extractLicenses": false,
"sourceMap": true,
"namedChunks": true
},
"staging": {
"baseHref": "/ui--staging/ccf-rui/",
"fileReplacements": [
{
"replace": "apps/ccf-rui/src/environments/environment.ts",
"with": "apps/ccf-rui/src/environments/environment.staging.ts"
}
],
"optimization": true,
"outputHashing": "none",
"sourceMap": false,
"namedChunks": false,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
"budgets": [
{
"type": "initial",
"maximumWarning": "2mb",
"maximumError": "5mb"
},
{
"type": "anyComponentStyle",
"maximumWarning": "6kb",
"maximumError": "10kb"
}
]
},
"preview": {
"baseHref": "/apps/ccf-rui/",
"buildOptimizer": false,
"optimization": false,
"vendorChunk": true,
"extractLicenses": false,
"sourceMap": true,
"namedChunks": true
}
},
"defaultConfiguration": ""
"defaultConfiguration": "production"
},
"serve": {
"executor": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "ccf-rui:build"
},
"executor": "@nx/angular:dev-server",
"configurations": {
"production": {
"browserTarget": "ccf-rui:build:production"
"buildTarget": "ccf-rui:build:production"
},
"staging": {
"browserTarget": "ccf-rui:build:staging"
"development": {
"buildTarget": "ccf-rui:build:development"
}
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
Expand All @@ -137,6 +129,9 @@
"apps/ccf-rui/src/app/**/*.module.ts"
],
"styles": ["apps/ccf-rui/src/styles.scss"],
"stylePreprocessorOptions": {
"includePaths": ["libs/design-system/styles"]
},
"scripts": []
}
},
Expand All @@ -147,7 +142,7 @@
}
},
"build-webcomponent": {
"command": "node tools/scripts/build-webcomponent.mjs ccf-rui"
"command": "node tools/scripts/bundle-scripts.mjs dist/apps/ccf-rui/"
},
"compodoc": {
"executor": "@twittwer/compodoc:compodoc",
Expand Down
77 changes: 53 additions & 24 deletions apps/ccf-rui/src/app/app.component.html
Original file line number Diff line number Diff line change
@@ -1,24 +1,53 @@
<ccf-registration-modal></ccf-registration-modal>
<ccf-header
[class.header-hidden]="(header$ | async) === false"
[logoTooltip]="(logoTooltip$ | async) ?? ''"
[homeUrl]="(homeUrl$ | async) ?? ''"
></ccf-header>

<ccf-drawer-container>
<ccf-drawer opened>
<ccf-left-sidebar [modalClosed]="registrationStarted"> </ccf-left-sidebar>
<ccf-drawer-toggle-button></ccf-drawer-toggle-button>
</ccf-drawer>
<ccf-drawer position="end" opened>
<ccf-right-sidebar
[modalClosed]="registrationStarted"
(registrationExpanded)="registrationToggle($event)"
></ccf-right-sidebar>
<ccf-drawer-toggle-button></ccf-drawer-toggle-button>
</ccf-drawer>

<ccf-drawer-content>
<ccf-content class="stage-content" [disablePositionChange]="disablePositionChange"></ccf-content>
</ccf-drawer-content>
</ccf-drawer-container>
<hra-nav-header-buttons
app="rui"
appLink="https://apps.humanatlas.io/rui/"
appTitle="Registration User Interface"
[brandmark]="true"
></hra-nav-header-buttons>
<ccf-left-sidebar [modalClosed]="registrationStarted"> </ccf-left-sidebar>
<hra-expansion-panel [title]="'Registration'" disabled class="registration">
<hra-expansion-panel-actions>
<button mat-icon-button [matMenuTriggerFor]="menu" hraIconButtonSize="large" aria-label="Icon to open nested menu">
<mat-icon>more_vert</mat-icon>
</button>
<mat-menu #menu="matMenu">
<button mat-menu-item matRipple matRippleColor="#201E3D14" (click)="resetStage()">Reset all</button>
<mat-divider class="menu-divider"></mat-divider>
<button mat-menu-item matRipple matRippleColor="#201E3D14" (click)="resetCamera()">Reset camera view</button>
<button mat-menu-item matRipple matRippleColor="#201E3D14" (click)="resetBlock()">Reset tissue block</button>
<mat-divider class="menu-divider"></mat-divider>
<button mat-menu-item matRipple matRippleColor="#201E3D14" (click)="resetMetadata()">
Reset registration metadata
</button>
</mat-menu>
</hra-expansion-panel-actions>
<hra-expansion-panel-header-content>
<mat-button-toggle-group
name="sideSelect"
aria-label="Side Select"
hideSingleSelectionIndicator
hraButtonToggleSize="medium"
(change)="updateSide($event.value)"
>
<mat-button-toggle value="left">Left</mat-button-toggle>
<mat-button-toggle value="right">Right</mat-button-toggle>
<mat-button-toggle value="anterior" checked>Anterior</mat-button-toggle>
<mat-button-toggle value="posterior">Posterior</mat-button-toggle>
</mat-button-toggle-group>
<mat-button-toggle-group
name="modeSelect"
aria-label="Mode Select"
hideSingleSelectionIndicator
hraButtonToggleSize="medium"
(change)="updateView($event.value === 'preview')"
>
<mat-button-toggle value="register" checked>Register</mat-button-toggle>
<mat-button-toggle value="preview">Preview</mat-button-toggle>
</mat-button-toggle-group>
</hra-expansion-panel-header-content>
</hra-expansion-panel>
<ccf-content class="stage-content" [disablePositionChange]="disablePositionChange"></ccf-content>
<ccf-right-sidebar
[modalClosed]="registrationStarted"
(registrationExpanded)="registrationToggle($event)"
></ccf-right-sidebar>
Loading
Loading