Rui update application r8 #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6fa38f7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
… into rui-update-application-r7
🚀 Preview Deploy Report Updated✅ Successfully deployed preview here |
…consortium/hra-ui into rui-update-application-r7
axdanbol
requested changes
Dec 4, 2024
apps/ccf-rui/src/app/shared/components/rotation-slider/rotation-slider.component.html
Outdated
Show resolved
Hide resolved
apps/ccf-rui/src/app/shared/components/rotation-slider/rotation-slider.component.html
Outdated
Show resolved
Hide resolved
apps/ccf-rui/src/app/shared/components/rotation-slider/rotation-slider.component.ts
Outdated
Show resolved
Hide resolved
apps/ccf-rui/src/app/shared/components/tag-search/tag-search.component.html
Outdated
Show resolved
Hide resolved
...ponents/spatial-search-keyboard-ui-behavior/spatial-search-keyboard-ui-behavior.component.ts
Outdated
Show resolved
Hide resolved
...ared/src/lib/components/spatial-search-keyboard-ui/spatial-search-keyboard-ui.component.html
Outdated
Show resolved
Hide resolved
...ared/src/lib/components/spatial-search-keyboard-ui/spatial-search-keyboard-ui.component.scss
Outdated
Show resolved
Hide resolved
|
axdanbol
approved these changes
Dec 9, 2024
axdanbol
added a commit
that referenced
this pull request
Dec 13, 2024
* Add violin plots by type * Improvements to violin plot * Update violin plot upload settings * Improvements * Refactor visualizations * Testing * Upload Data module updates * Upload Data style updates * Add column header checking * Add configure parameters card + styling updates * Color map selection updates * Fix validation of inputs * Move column header errors to step 2; styling improvements * Remove unused code * Set headers in submitted data to selected values * Fix cell types check * Fix broken tests * Increase testing and doc coverage * Fix test * Fix sonarcloud issues * Add ontologyId to submitted data * Add unified letter casing for headers; add headers to edge csv file downloads * Renaming and tweaks * Renaming * Set up design system theming * update cell type component * update path of main in cde lib project.json * update theme * Change create vis page styles to use design system * add links count to cell type table * More style updates * Make styles closer to spec * Remove redundant assets * add toggle links column functionality * compute columns based on the links visibility signal * fix toggle signal for cell links * fix tests for downloads * update snackbar timer * add noreferrer to link * add micro tooltip to cell types module * update padding and selected color for button toggle * Rename edge headers * Remove lodash * create expansion panel * add animation to expansion panel * update peer deps * improve test coverage * add height check in tests for expansion panel * update icon button size and styles in the design system * update design file in the icon button stories * refactor animation code * Cde nav header updates (#778) * Update app logos component * Add sidenav to nav header and update landing page * Add product logos to design system * Update nav header with product logo DS component * Rename App Logos to Nav Header Buttons * Add software status indicator * Updates to nav header components * Small changes to nav header styles * Adjust header styling * Remove duplication * Software status indicator updates * Updates to sidenav demo * Sidenav updates * Tweaks * Testing and documentation * Fix testing * Node dist vis (#758) * initial setup of library + wc in apps * create services for nodes and edges * refactor node data service * update peer dependencies * create deck gl visualization component * update peer deps * improve doc coverage * refactor: Node dist vis data format update (WIP) * refactor: lint fix * refactor(node-dist-vis): Remove export * feat(lib:common): Create library 'common' * refactor(lib:common): Move file loaders into 'common/fs' * refactor(node-dist-vis): Implement data loading * chore: Lint fix * refactor(node-dist-vis): ⚰️ Remove unused data services * refactor(node-dist-vis): Add mode logic (WIP), improve filters (WIP), & tweaks * refactor(node-dist-vis): Implement improved node filtering & minor fixes * fix(node-dist-vis): Fix edge filtering bug * test(node-dist-vis): Remove test files until jest + deck.gl is figured out * test(cde-visualization): Fix a couple of imports * refactor(node-dist-vis): Cleanup & code smell fixes * refactor(node-dist-vis): 📝 Add documentation & minor type and error handling tweaks * refactor(node-dist-vis): Remove test data --------- Co-authored-by: Daniel Bolin <[email protected]> * Remove size option and adjust spacing in breadcrumbs (#789) * Remove size option and adjust spacing in breadcrumbs * Remove disableRipple * Cde design system (#773) * Use design system for cde-visualization * Update landing page to use design system * More style updates for tooltips and visualization page * Change violin vis size * Fix build issue * Update testing * Tweaks * Use error indicator component in design system * Add delete file button to design system and cde * Remove export * Fix bugs in file upload * Add workflow card to design system and cde * Add load progress bar to workflow cards * Remove commented out code * Improve progress bar * Tweaks * Update tests * Create info modal component with two variants (#794) * Create info modal component with two variants * Use mat icon button for close icon * Add doc coverage; width adjustments * Aria label * Design system menu updates (#793) * Remove menu size option and update menu button states * Button tweaks * Remove unused import * Build improvements (#796) * build(node-dist-vis): 🏗️ Disable chunk splitting in build, remove zone, and bundle scripts and workers in build-webcomponent step * build(cde): 🏗️ Update build configuration * fix: Fix resolve path in bundle-scripts.mjs * Update styles for tree nodes and buttons (#797) * Cde improvements (#799) * Change cde logo home link to '/' * Fix background colors on visualization page * Disable Organize Data and Configure Parameters until data set uploaded * Fix HRA logo width in header (Firefox) * update metadata, histogram, visualization, violin plot modules component (#772) * update metadata module * add micro tooltip to metadata * update histogram component * update grid size and histogram * update visualization menu * fix imports * update css for vis page and its modules * fix tests for cell types module * improve test coverage for cde-vis lib * add dialog for fullscreen * fix test for fullscreen component * improve doc coverage for full screen component * improve test coverage * fix histogram header css * use custom expansion panel in the histogram * use expansion panel in sample metadata * use expansion panel for cell types module * use expansion panel in cell types and violin graph * use fullscreen for all modules on vis page * use expansion panel and fullscreen portal for visualization module on vis page * update logic for fullscreen dialog * fix visualization height in expansion panel * fix overflowing of content in expansion panel * fix scrolling of cell types and violin plot * minor fixes to vis page * fix height issue of node dist vis * fix histogram resizing in fullscreen mode * remove svg renderer from downloads for histogram * fix imports * update violin plot config * write tests for tree size directive * write test for select size directive * fix scrollbar position in violin component * fix histogram all cells color picker * fix violin container width * add histogram menu component * create violin menu component * fix color picker tooltip * fix css block * improve design system test coverage * improve cde-vis test coverage * improve doc coverage * Update text field appearance (#802) * Update text field appearance * Add validation to storybook inputs; Change error state color * Hra rui update 2 (#807) * update rui app structure * update theme and other css * use grid as main layout * update tissue block settings * fix tissue block css * fix AS tags input search css * update opacity slider css * update build webcomponent command for rui * add functionality to registration toggle * update output path * update content css * Remove unneeded test * Disable tests --------- Co-authored-by: edlu77 <[email protected]> * Rui registration modal r7 (#809) * update rui app structure * update theme and other css * use grid as main layout * Add hra design system * update tissue block settings * fix tissue block css * fix AS tags input search css * update opacity slider css * update build webcomponent command for rui * Refactor form inputs * Fix sex select height * add functionality to registration toggle * update output path * update content css * More fixes to inputs * Add email to required user inputs * Remove unneeded state updates * Add subheaders * Remove unneeded test * Disable tests * Add consortium and doi data entries; more tweaks to modal * Testing * Add help menu * Adjust background color * Add responsiveness updates * Add screen size notice * More styling tweaks * Test * Split registration form into component * Update doi and consortium in model state --------- Co-authored-by: Bhushan Khope <[email protected]> * chore: Regenerate package-lock * fix: * test(cde-visualization): Fix tests mangled by merge * refactor: Fix more merge issues * Rui update application r8 (#832) * Left sidebar changes * Clean up left sidebar styles * Styling and removing old theming files * Right side cosmetic changes * Update styles in Anatomical Structure Tags * Update usage tracking popup * Remove obsolete styling files / components * Fix unwanted block movement during form inputs * Update checkbox focus color * Fix broken theming file in EUI * Add updated rotation slider * Add updated rotation slider * Rotation slider and keyboard-ui fixes * Fix * Rotation slider updates * Update opacity flyout * Remove HostListener, other improvements * Separate slider box into separate component * Fix options in Tissue Block Settings * Add dividers to menus * Fix registration and help menu options * CSS fixes * Display block properly on initial load * Fix for visibility menu icons and opacity settings * Rui update review and download modal (#849) * Snackbar styling fix for EUI (temporary) * Use correct placement target in example registration * Update metadata for registration review * Delete deprecated registration metadata component * Review modal cosmetic updates * Remove console log * Add download snackbar * Testing * Add tooltips to page (#853) * Rui metadata registration form (#857) * refactor(ccf-rui): Move screen size notice logic * feat(design-system): Add full workflow card component * build: ➕ Add ngx-mask * refactor(ccf-rui): Refactored metadata registration form/dialog * fix(ccf-rui): 🩹 Improve orcid handling * fix(ccf-rui): Disable update metadata button until the user has made changes * refactor(ccf-rui): Tweak thickness & numSlices * test(ccf-rui): ✅ Fix tests * docs(design-system): Increase doc coverage for design system * Updated logic to handle when we have newer versions of HRA v2.0+ reference organs and no direct spatial placement patch. * Rui tweaks & bug fixes (#862) * fix(ccf-rui): Update 'title' bindings to always use brackets * refactor(ccf-rui): ⚰️ Remove old name-input component * refactor(ccf-rui): ⚰️ Remove json-file-reader. Replaced by file-upload component * refactor(ccf-rui): ⚰️ Remove old drawer components * refactor(ccf-rui): Tweak metadata input fields * refactor(ccf-rui): ⚰️ Remove commented out and dead code * refactor(design-system): Rename workflow card components --------- Co-authored-by: edlu77 <[email protected]> Co-authored-by: Bhushan Khope <[email protected]> Co-authored-by: Bruce W. Herr II <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#736 Cosmetic updates to RUI app