Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John conroy/search last page #3640

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

john-conroy
Copy link
Collaborator

Summary

Phil noticed a bug scrolling through deeper search pages. The sort_after requires a unique tiebreaker.

From Phil:

The "see more results" stops working before it gets to the very end of the list of datasets (see snapshot where it stopped revealing more datasets)

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

@john-conroy john-conroy merged commit 54d4450 into main Dec 6, 2024
8 checks passed
@john-conroy john-conroy deleted the john-conroy/search-last-page branch December 6, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants