Skip to content

fix(client-proxy): support Windows wininet format - #329

Merged
cratelyn merged 2 commits into
hyperium:masterfrom
dswij:windows-proxy-parsing
Sep 29, 2026
Merged

cratelyn merged 2 commits into
hyperium:masterfrom
dswij:windows-proxy-parsing

Conversation

@dswij

@dswij dswij commented Sep 26, 2026

Copy link
Copy Markdown
Member

Closes hyperium/hyper#4067

This PR adds support for parsing multiple proxy configuration in windows.

Previously, any string value in HKCU\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyServer is parsed verbatim. After the change, these formats are now supported in Windows:

  1. destination (assumes http scheme, applied to all)
  2. scheme=destination
  3. scheme1=destination1;scheme2=destination2

Also some minor restructuring of the proxy module.


@dswij
dswij force-pushed the windows-proxy-parsing branch 2 times, most recently from cea28f3 to eb34b0b Compare September 28, 2026 04:56
@dswij
dswij force-pushed the windows-proxy-parsing branch from eb34b0b to 30930ec Compare September 28, 2026 05:12

@cratelyn cratelyn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, @dswij. thank you for doing this!

@cratelyn cratelyn added A-client Area: client. C-fix Category: bug fix. This is fixing a bug. labels Sep 28, 2026
@cratelyn
cratelyn merged commit a7bf164 into hyperium:master Sep 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-client Area: client. C-fix Category: bug fix. This is fixing a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows system proxy: per-scheme ProxyServer format (e.g. socks=127.0.0.1:1080) not parsed

2 participants