Refactor didcore, remove generics from DidDocument

Signed-off-by: Patrik Stas <[email protected]>

.github/workflows/main.yml

@@ -377,7 +377,7 @@ jobs:
           default: true
       - name: "Run resolver tests"
         run: |
-          cargo test --examples -p did_doc -p did_parser -p did_resolver -p did_resolver_registry -p did_resolver_sov -p did_resolver_web -p did_doc_sov -p did_key -p did_peer --test "*"
+          cargo test --examples -p did_doc -p did_parser -p did_resolver -p did_resolver_registry -p did_resolver_sov -p did_resolver_web -p did_key -p did_peer --test "*"
 
   test-integration-node-wrapper:
     needs: workflow-setup

Cargo.toml

@@ -23,7 +23,6 @@ members = [
     "did_core/did_doc",
     "did_core/did_methods/did_peer",
     "did_core/did_methods/did_key",
-    "did_core/did_doc_sov",
     "did_core/did_parser",
     "did_core/did_parser_nom",
     "did_core/did_resolver",

aries/agents/node/.gitignore

@@ -70,6 +70,6 @@ typings/
 # End of https://www.gitignore.io/api/node
 
 
-vcxagent-core/storage-proofs/
+vcxagent-core/storage-*
 
 **/test/tmp

aries/agents/rust/aries-vcx-agent/src/agent/init.rs

@@ -2,9 +2,10 @@ use std::sync::Arc;
 
 use aries_vcx::{
     common::ledger::{
-        service_didsov::{DidSovServiceType, EndpointDidSov},
+        service_didsov::EndpointDidSov,
         transactions::{add_new_did, write_endpoint},
     },
+    did_doc::schema::service::typed::ServiceType,
     global::settings::DEFAULT_LINK_SECRET_ALIAS,
 };
 use aries_vcx_core::{
@@ -106,7 +107,7 @@ impl Agent {
         .await?;
         let endpoint = EndpointDidSov::create()
             .set_service_endpoint(init_config.service_endpoint.clone())
-            .set_types(Some(vec![DidSovServiceType::DidCommunication]));
+            .set_types(Some(vec![ServiceType::DIDCommV1.to_string()]));
         write_endpoint(
             wallet.as_ref(),
             ledger_write.as_ref(),
@@ -130,7 +131,6 @@ impl Agent {
             init_config.service_endpoint.clone(),
         ));
         let did_exchange = Arc::new(ServiceDidExchange::new(
-            ledger_read.clone(),
             wallet.clone(),
             did_resolver_registry,
             init_config.service_endpoint.clone(),

aries/agents/rust/aries-vcx-agent/src/error/convertors.rs

@@ -2,11 +2,11 @@ use std::convert::From;
 
 use aries_vcx::{
     did_doc::error::DidDocumentBuilderError,
-    did_doc_sov::error::DidDocumentSovError,
     errors::error::{AriesVcxError, AriesVcxErrorKind},
     protocols::did_exchange::state_machine::generic::GenericDidExchange,
 };
 use aries_vcx_core::errors::error::AriesVcxCoreError;
+use did_resolver_sov::did_resolver::did_doc::schema::utils::error::DidDocumentLookupError;
 
 use crate::error::*;
 
@@ -30,7 +30,6 @@ impl From<serde_json::Error> for AgentError {
     }
 }
 
-// TODO
 impl From<AriesVcxCoreError> for AgentError {
     fn from(err: AriesVcxCoreError) -> Self {
         let kind = AgentErrorKind::GenericAriesVcxError;
@@ -39,14 +38,6 @@ impl From<AriesVcxCoreError> for AgentError {
     }
 }
 
-impl From<DidDocumentSovError> for AgentError {
-    fn from(err: DidDocumentSovError) -> Self {
-        let kind = AgentErrorKind::GenericAriesVcxError;
-        let message = format!("DidDocumentSovError; err: {:?}", err.to_string());
-        AgentError { message, kind }
-    }
-}
-
 impl From<DidDocumentBuilderError> for AgentError {
     fn from(err: DidDocumentBuilderError) -> Self {
         let kind = AgentErrorKind::GenericAriesVcxError;
@@ -63,6 +54,14 @@ impl From<aries_vcx::did_parser::ParseError> for AgentError {
     }
 }
 
+impl From<did_peer::error::DidPeerError> for AgentError {
+    fn from(err: did_peer::error::DidPeerError) -> Self {
+        let kind = AgentErrorKind::GenericAriesVcxError;
+        let message = format!("DidPeerError; err: {:?}", err.to_string());
+        AgentError { message, kind }
+    }
+}
+
 impl From<public_key::PublicKeyError> for AgentError {
     fn from(err: public_key::PublicKeyError) -> Self {
         let kind = AgentErrorKind::GenericAriesVcxError;
@@ -86,6 +85,13 @@ impl From<(GenericDidExchange, AriesVcxError)> for AgentError {
         AgentError { message, kind }
     }
 }
+impl From<DidDocumentLookupError> for AgentError {
+    fn from(err: DidDocumentLookupError) -> Self {
+        let kind = AgentErrorKind::GenericAriesVcxError;
+        let message = format!("DidDocumentLookupError; err: {:?}", err.to_string());
+        AgentError { message, kind }
+    }
+}
 
 impl From<anoncreds_types::Error> for AgentError {
     fn from(err: anoncreds_types::Error) -> Self {

aries/agents/rust/aries-vcx-agent/src/http.rs

@@ -6,7 +6,7 @@ pub struct VcxHttpClient;
 
 #[async_trait]
 impl Transport for VcxHttpClient {
-    async fn send_message(&self, msg: Vec<u8>, service_endpoint: Url) -> VcxResult<()> {
+    async fn send_message(&self, msg: Vec<u8>, service_endpoint: &Url) -> VcxResult<()> {
         shared::http_client::post_message(msg, service_endpoint).await?;
         Ok(())
     }

aries/agents/rust/aries-vcx-agent/src/lib.rs

@@ -9,7 +9,6 @@ extern crate uuid;
 
 mod agent;
 mod error;
-pub mod helper;
 mod http;
 mod services;
 mod storage;