Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused oob APIs, move code to libvcx_core #1039

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Oct 29, 2023

  1. Remove obscure APIs on OOB receiver handler (which can eventually be ?perhaps? also deleted). Deleted methods:
  • connection_exists
  • nonmediated_connection_exists
  • build_connection
  1. Move code only used by libvcx_core from aries_vcx to libvcx_core
  • State enums -> u32 conversions
  • *_find_message_to_handle functions
  1. Rename .*Connection.* types to .*MediatedConnection.* to avoid confusion

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@88f6e8e). Click here to learn what that means.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##             main   #1039   +/-   ##
======================================
  Coverage        ?   0.05%           
======================================
  Files           ?     379           
  Lines           ?   21077           
  Branches        ?    3775           
======================================
  Hits            ?      12           
  Misses          ?   21064           
  Partials        ?       1           
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aries_vcx/src/handlers/out_of_band/receiver.rs 0.00% <ø> (ø)
aries_vcx/src/handlers/out_of_band/sender.rs 0.00% <ø> (ø)
aries_vcx/src/handlers/util.rs 0.00% <ø> (ø)
...ocols/mediated_connection/inviter/state_machine.rs 0.00% <0.00%> (ø)
...ocols/mediated_connection/invitee/state_machine.rs 0.00% <0.00%> (ø)
aries_vcx/src/handlers/mediated_connection/mod.rs 0.00% <0.00%> (ø)

@Patrik-Stas Patrik-Stas marked this pull request as ready for review November 1, 2023 21:25
@Patrik-Stas Patrik-Stas requested a review from mirgee November 2, 2023 14:12
@Patrik-Stas Patrik-Stas changed the title Remove unnecessary oob features Remove unused oob APIs, move code to libvcx_core Nov 2, 2023
Signed-off-by: Patrik Stas <[email protected]>
@Patrik-Stas Patrik-Stas merged commit 9bb6bf5 into main Nov 7, 2023
27 checks passed
@Patrik-Stas Patrik-Stas deleted the delete/oob-features branch November 7, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants