Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve record category type, closes #1112 #1123

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

xprazak2
Copy link
Contributor

@xprazak2 xprazak2 commented Feb 7, 2024

Replace a string type with enum.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (cb28bad) 0.05% compared to head (cb8ae01) 0.05%.

Files Patch % Lines
...vcx_core/src/wallet/base_wallet/record_category.rs 0.00% 36 Missing ⚠️
...ies_vcx_core/src/wallet/indy/indy_record_wallet.rs 0.00% 13 Missing ⚠️
...es/misc/wallet_migrator/src/vdrtools2credx/conv.rs 0.00% 12 Missing ⚠️
aries/aries_vcx_core/src/wallet/indy/mod.rs 0.00% 7 Missing ⚠️
aries/misc/test_utils/src/mock_wallet.rs 0.00% 6 Missing ⚠️
...ries_vcx_core/src/anoncreds/credx_anoncreds/mod.rs 0.00% 5 Missing ⚠️
.../aries_vcx_core/src/wallet/agency_client_wallet.rs 0.00% 5 Missing ⚠️
...es/aries_vcx_core/src/wallet/base_wallet/record.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1123      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        497     498       +1     
  Lines      25298   25339      +41     
  Branches    4597    4613      +16     
========================================
  Hits          13      13              
- Misses     25285   25326      +41     
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xprazak2 xprazak2 force-pushed the car-clean branch 4 times, most recently from 6b3431b to da26c90 Compare February 7, 2024 13:15
@xprazak2 xprazak2 force-pushed the car-clean branch 10 times, most recently from 43fc5c2 to 5cba8c7 Compare February 13, 2024 13:35
@xprazak2 xprazak2 marked this pull request as draft February 13, 2024 13:43
@xprazak2 xprazak2 force-pushed the car-clean branch 3 times, most recently from 8f7f4b3 to 6c9f125 Compare February 13, 2024 14:31
@xprazak2 xprazak2 marked this pull request as ready for review February 13, 2024 14:32
mirgee
mirgee previously approved these changes Feb 16, 2024
Patrik-Stas
Patrik-Stas previously approved these changes Feb 16, 2024
@Patrik-Stas Patrik-Stas merged commit e88b70e into main Feb 16, 2024
27 checks passed
@Patrik-Stas Patrik-Stas deleted the car-clean branch February 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants