build: fix the invalid tag when calling docker:publishLocal #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FabioPinheiro <[email protected]>
FabioPinheiro
force-pushed
the
fix/docker_publishLocal_invalid_tag
branch
from
ed8a849 to
dbeb293
Compare
mineme0110
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an regression when calling docker:publishLocal one stable versions or dirty commit
In docker "The tag must be valid ASCII and can contain lowercase and uppercase letters, digits, underscores, periods, and hyphens"
I see a
+in the default generated version (1.0.0+6-1bdc62a6+20241225-0337-SNAPSHOT)The default generated version is preferable instead of the one that we introduced before (with over complicated logic). It was removed because it was causing caching problems another places.
The solution was to replace all
+for_in SBT's docker:publishLocal command.This problem was report on Discord by
kid0410https://discord.com/channels/1146426895114702858/1156506829287850025/1321321978862506029