Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get example.html files to work #5

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Trying to get example.html files to work #5

merged 5 commits into from
Sep 10, 2024

Conversation

sverhoeven
Copy link
Member

Need to try

  • different esm hosting services
  • to ngl to bundle
  • figure out why React.createElement() is used in downloaded files, and dist has _jsx()

```
react-dom.production.min.js:127 Uncaught ReferenceError: React is not defined
    at Qv (molviewer.tsx:569:3)
    at $i (react-dom.production.min.js:160:137)
    at ca (react-dom.production.min.js:289:337)
    at oa (react-dom.production.min.js:279:389)
    at hf (react-dom.production.min.js:279:320)
    at jr (react-dom.production.min.js:279:180)
    at hi (react-dom.production.min.js:270:88)
    at mo (react-dom.production.min.js:272:300)
    at on (react-dom.production.min.js:127:105)
    at react-dom.production.min.js:266:273
```
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.05%. Comparing base (1adfa4b) to head (5d623f2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   15.05%   15.05%           
=======================================
  Files          15       15           
  Lines         372      372           
  Branches       84       84           
=======================================
  Hits           56       56           
  Misses        233      233           
  Partials       83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sverhoeven
Copy link
Member Author

Seems like v0.2.0 release is broken, but files in node_modules/@i-vresse/haddock3-ui/dist/ do not use React.createElement, while remix/vite is pushing React.* to the browser.

Commit 0c80392 fixed
after build + copying dist folder haddock3-webapp.
The haddock3-webapp build+start works and after rm node_modules/.vite the npm run dev also works.

@sverhoeven sverhoeven marked this pull request as ready for review September 10, 2024 14:55
@sverhoeven sverhoeven merged commit 1c31894 into main Sep 10, 2024
4 checks passed
@sverhoeven sverhoeven deleted the examplehtml branch September 10, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant