-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to get example.html files to work #5
Conversation
``` react-dom.production.min.js:127 Uncaught ReferenceError: React is not defined at Qv (molviewer.tsx:569:3) at $i (react-dom.production.min.js:160:137) at ca (react-dom.production.min.js:289:337) at oa (react-dom.production.min.js:279:389) at hf (react-dom.production.min.js:279:320) at jr (react-dom.production.min.js:279:180) at hi (react-dom.production.min.js:270:88) at mo (react-dom.production.min.js:272:300) at on (react-dom.production.min.js:127:105) at react-dom.production.min.js:266:273 ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage 15.05% 15.05%
=======================================
Files 15 15
Lines 372 372
Branches 84 84
=======================================
Hits 56 56
Misses 233 233
Partials 83 83 ☔ View full report in Codecov by Sentry. |
Seems like v0.2.0 release is broken, but files in node_modules/@i-vresse/haddock3-ui/dist/ do not use React.createElement, while remix/vite is pushing React.* to the browser. Commit 0c80392 fixed |
Need to try