Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/quest sdk no boundary #737

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Fix/quest sdk no boundary #737

merged 6 commits into from
Jul 9, 2024

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Jul 8, 2024

No description provided.

@andybak andybak requested review from mikeage and mikeskydev July 8, 2024 10:05
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest parts look good (edit: I thought it looks good, but it didn't actually work. Type mismatches). I know we shouldn't look too carefully at Unity files, but normally it's just additions -- here there were some things that seem to have been removed or disabled. Deliberate?

Also, I'd like to test an upload for Quest on this branch -- any objections if I push a commit, later to be reverted, to try this?

Assets/Oculus/OculusProjectConfig.asset Outdated Show resolved Hide resolved
Assets/Oculus/OculusProjectConfig.asset Show resolved Hide resolved
@andybak
Copy link
Contributor Author

andybak commented Jul 8, 2024

All the changes in the Unity files were by Unity - I didn't change anything manually except updating the package version

@andybak
Copy link
Contributor Author

andybak commented Jul 8, 2024

I'm going to try reverting the changes to those files locally to see if the new sdk automatically makes the same changes again.

@mikeage
Copy link
Member

mikeage commented Jul 8, 2024

ok. Also note that the Mac failure was a real failure, but perhaps we just need to delete the package cache

@mikeage
Copy link
Member

mikeage commented Jul 8, 2024

The Mac failure is real, but I think we should probably just be removing the package on Mac

@andybak andybak marked this pull request as ready for review July 8, 2024 19:01
@andybak andybak merged commit 97b3680 into main Jul 9, 2024
42 checks passed
@andybak andybak deleted the fix/quest-sdk-no-boundary branch July 9, 2024 07:39
@andybak andybak added the bugfix Something has been fixed label Jul 9, 2024
@andybak andybak restored the fix/quest-sdk-no-boundary branch July 9, 2024 21:33
@mikeage mikeage mentioned this pull request Sep 9, 2024
@mikeage mikeage deleted the fix/quest-sdk-no-boundary branch October 14, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants