convert Select Case [object]
using Operators.ConditionalCompareObject...
#1128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1100:
Select Case [object]
can have incorrect converted codeSolution
GetFullExpressionForVbObjectComparison
now has aComparisonKind
parameter (new enum).VisitSelectBlock
now checks if expression type is object first, in which case different code is generated.ComparisonKind
hasUnknown
value, which might not be necessary - I added it in case something goes terribly wrong.ComparisonAdjustedForStringComparison()
(renamed fromEqualsAdjustedForStringComparison()
) hasreturn SyntaxFactory.BinaryExpression(GetSyntaxKind(comparisonKind), csLeft, csRight);
for the non-Object case. With how the code currently looks like, thecomparisonKind
will always beEquals
here (i.e. the call toGetSyntaxKind(comparisonKind)
is unnecessary). I've added it for completeness sake, because otherwise the method could return unexpected ExpressionSyntax should it ever be used somewhere else.