Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible ObservableCollection re-entrance crash when trying to na… #3294

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Fix possible ObservableCollection re-entrance crash when trying to na… #3294

merged 1 commit into from
Sep 28, 2024

Conversation

tom-englert
Copy link
Contributor

…vigate to a collapsed item.

@siegfriedpammer siegfriedpammer merged commit 64cbcd4 into icsharpcode:master Sep 28, 2024
5 checks passed
@siegfriedpammer
Copy link
Member

Thank you very much!

@siegfriedpammer
Copy link
Member

Looking at ILSpy/AssemblyTree/AssemblyTreeModel.cs as a whole I see that we sometimes do a null check (or ?) on activeView and sometimes don't. Is this intentional?

@tom-englert
Copy link
Contributor Author

I think that should be always, I'm just not used to work without NRTs enabled 😔

@tom-englert
Copy link
Contributor Author

I'll fix this

@siegfriedpammer
Copy link
Member

siegfriedpammer commented Sep 28, 2024 •
edited
Loading

you can enable NRT on any file you touch, if you think it makes work easier... however, please not all files at once... that will be a pain to review and there already is some work done in #3295 #3287 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-englert @siegfriedpammer