Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix failing windows tests #333

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

dylanjm
Copy link
Collaborator

@dylanjm dylanjm commented Jan 24, 2024


Pull Request Description

What issue does this change request address?

#74

What are the significant changes in functionality due to this change request?

This pins two tests to using cbc as a solver. There was previously a descrepancy with the needed_executable specified in the test file and the solver actually used in the test. This PR just ensures that the tests files and the input file match up.

Will most likely result in the PyomoOptions and Storage test to be skipped on our Windows test machine


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL
Copy link
Collaborator

Hm, I don't love how many tests have to be skipped on Windows due to ipopt and/or cbc missing. Opening issue #334 to track fixing this. Otherwise, good to go.

@PaulTalbot-INL PaulTalbot-INL merged commit 5e830ee into idaholab:devel Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants