Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] awesome-code-style
[x] Run all linters in tests
[x] strictNullChecks: true
[x] strict: true
[x] noUnusedParameters : true
[x] noUnusedLocals : true
[x] esModuleInterop: true
[ ] No TDI (** see marks below)
[ ] Jest (%%% see marks below)
%%%
For Jest, I added 2 of 4 tests into Jest tests, and they passed. However, the other 2 mocha tests failed even before transferring to Jest. So I just keep the 2 mocha tests as is for now. Here is the mocha tests' failure log:
**
For TDI, some of the types we use from
tdi
are different from what I could get from@types/...
.For example, for
stream-json
lib, the types from@types/stream-json
(https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/stream-json/index.d.ts) are different from what we have intdi
(https://github.com/implydata/tdi/blob/master/typings/stream-json/index.d.ts).Another example is
readable-stream
lib. TypeReadableStream
exists intdi
(https://github.com/implydata/tdi/blob/master/typings/readable-stream/index.d.ts), but not in@types.readable-stream
(https://github.com/DefinitelyTyped/DefinitelyTyped/blob/36ddc60d7c4734d6c6593d1ab3273b72afae68ef/types/readable-stream/index.d.ts).So I didn't delete
tdi
in this repo.