Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace personal info for publishing with Infinum's info #84

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Replace personal info for publishing with Infinum's info #84

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc2849
Replace personal info for publishing with Infinum's info
KCeh Sep 10, 2024
3f818c6
Add additional publishing info for organisation
KCeh Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sentinel-no-op/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is team.android the best option? Any email that goes there is received by the entire team, and that could end up being a bit spammy 🤔 I'd prefer if we had a dedicated email for this.
cc @Aksi0m

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might even remove email
And move to

organization {
                        name = 'Infinum Inc.'
                        url = 'https://infinum.com'
                    }

instead of developer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed email from developer info. Since repos are public there is no barrier in reporting issue on lib.

Also, IMO we should only have organization info. But I found that some tools that collect info for libs sometimes read only developers info and sometimes developer and organization infos are interchangeable.
This is why I added both developer and organization

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I agree 👍

}
}
scm {
Expand Down
6 changes: 3 additions & 3 deletions sentinel/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
}
}
scm {
Expand Down
6 changes: 3 additions & 3 deletions tool-appgallery/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
}
}
scm {
Expand Down
6 changes: 3 additions & 3 deletions tool-chucker/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
}
}
scm {
Expand Down
6 changes: 3 additions & 3 deletions tool-collar/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
}
}
scm {
Expand Down
6 changes: 3 additions & 3 deletions tool-dbinspector/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
}
}
scm {
Expand Down
6 changes: 3 additions & 3 deletions tool-googleplay/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
}
}
scm {
Expand Down
6 changes: 3 additions & 3 deletions tool-leakcanary/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
}
}
scm {
Expand Down
6 changes: 3 additions & 3 deletions tool-thimble/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
}
}
scm {
Expand Down
11 changes: 3 additions & 8 deletions tool-timber/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,9 @@ afterEvaluate {
}
developers {
developer {
id = 'knobtviker'
name = 'Bojan Komljenović'
email = '[email protected]'
}
developer {
id = 'gobbletsit'
name = 'Nikola Gobović'
email = '[email protected]'
id = 'Infinum'
name = 'Infinum Inc.'
email = '[email protected]'
}
}
scm {
Expand Down
Loading