Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic create connection cli #524

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Generic create connection cli #524

merged 9 commits into from
Jan 16, 2025

Conversation

seanchen1991
Copy link
Collaborator

Closes: #522

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen
Copy link
Collaborator

Great work! Can you remove the original implementation from crates/cli/cli/src/commands/connection/create.rs, and then use this generic implementation in the main CLI?

@soareschen soareschen merged commit ab0513f into main Jan 16, 2025
10 checks passed
@soareschen soareschen deleted the sean/generic-create-connection-cli branch January 16, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize create connection command
2 participants
@seanchen1991 @soareschen