Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relayer): implement poseidon hash #186

Merged
merged 29 commits into from
Jan 15, 2025
Merged

feat(relayer): implement poseidon hash #186

merged 29 commits into from
Jan 15, 2025

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Jan 11, 2025

Closes #175
Closes #180

  • move code to separate poseidon sub-crate

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting that there's no reference Rust implementation to use instead, so we wouldn't have to deal with these low-level details.
Anyway, great work here. Looks awesome to me!
Once everything is finalized, I'll give it one last review, and approve. Thx!

@rnbguy rnbguy force-pushed the rano/poseidon-hash branch from 2c4f159 to a6f754d Compare January 14, 2025 10:49
@rnbguy rnbguy force-pushed the rano/poseidon-hash branch from a3ec7e9 to 7428b94 Compare January 14, 2025 11:22
@rnbguy rnbguy force-pushed the rano/poseidon-hash branch from 7428b94 to aeefb02 Compare January 14, 2025 11:25
@rnbguy rnbguy force-pushed the rano/poseidon-hash branch from 946d4dc to 49b5c62 Compare January 14, 2025 11:44
@rnbguy rnbguy marked this pull request as ready for review January 14, 2025 12:09
@rnbguy rnbguy requested a review from Farhad-Shabani January 14, 2025 12:41
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment which I'll let you decide. Otherwise all set. Thanks

cairo-contracts/packages/utils/src/utils.cairo Outdated Show resolved Hide resolved
@rnbguy rnbguy merged commit 3684271 into main Jan 15, 2025
6 checks passed
@rnbguy rnbguy deleted the rano/poseidon-hash branch January 15, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants